------------------------------------------------------------ revno: 16725 committer: Lars Helge Overland <larshe...@gmail.com> branch nick: dhis2 timestamp: Mon 2014-09-15 22:06:58 +0200 message: Removed sortOrder property of data element, indicator, data set. Not used for anything. removed: dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/comparator/DataElementSortOrderComparator.java dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/comparator/DataSetSortOrderComparator.java dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/comparator/ dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/comparator/IndicatorSortOrderComparator.java dhis-2/dhis-api/src/main/java/org/hisp/dhis/program/comparator/ProgramStageDataElementSortOrderComparator.java modified: dhis-2/dhis-api/src/main/java/org/hisp/dhis/chart/ChartService.java dhis-2/dhis-api/src/main/java/org/hisp/dhis/dashboard/DashboardService.java dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataapproval/DataApprovalStateResponses.java dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/DataSet.java dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/Indicator.java dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/startup/TableAlteror.java dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataelement/hibernate/DataElement.hbm.xml dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataset/hibernate/DataSet.hbm.xml dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/indicator/hibernate/Indicator.hbm.xml dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/file/rowhandler/CaculatedDataElementRowHandler.java dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/xml/converter/DataElementConverter.java dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/xml/converter/IndicatorConverter.java dhis-2/dhis-services/dhis-service-mobile/src/main/java/org/hisp/dhis/mobile/service/ActivityReportingServiceImpl.java dhis-2/dhis-services/dhis-service-mobile/src/main/java/org/hisp/dhis/mobile/service/FacilityReportingServiceImpl.java dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/DataElementBatchHandler.java dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/DataSetBatchHandler.java dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/IndicatorBatchHandler.java dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/utils/FormUtils.java dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/webdomain/form/Field.java dhis-2/dhis-web/dhis-web-caseentry/src/main/java/org/hisp/dhis/caseentry/action/caseentry/LoadDataEntryAction.java dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-mobile/src/main/java/org/hisp/dhis/mobile/action/smscommand/SMSCommandAction.java dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/GetFilteredDataElementsAction.java
-- lp:dhis2 https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk Your team DHIS 2 developers is subscribed to branch lp:dhis2. To unsubscribe from this branch go to https://code.launchpad.net/~dhis2-devs-core/dhis2/trunk/+edit-subscription
=== modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/chart/ChartService.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/chart/ChartService.java 2014-09-11 06:39:30 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/chart/ChartService.java 2014-09-15 20:06:58 +0000 @@ -40,7 +40,6 @@ import org.hisp.dhis.indicator.Indicator; import org.hisp.dhis.organisationunit.OrganisationUnit; import org.hisp.dhis.period.Period; -import org.hisp.dhis.user.User; import org.jfree.chart.JFreeChart; import org.jfree.chart.axis.CategoryLabelPositions; import org.jfree.chart.plot.PlotOrientation; === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dashboard/DashboardService.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dashboard/DashboardService.java 2014-09-11 06:39:30 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dashboard/DashboardService.java 2014-09-15 20:06:58 +0000 @@ -28,15 +28,13 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import java.util.Set; + import org.hisp.dhis.chart.Chart; import org.hisp.dhis.document.Document; import org.hisp.dhis.mapping.Map; import org.hisp.dhis.report.Report; import org.hisp.dhis.reporttable.ReportTable; -import org.hisp.dhis.user.User; - -import java.util.List; -import java.util.Set; /** * @author Lars Helge Overland === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataapproval/DataApprovalStateResponses.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataapproval/DataApprovalStateResponses.java 2014-08-14 05:46:19 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataapproval/DataApprovalStateResponses.java 2014-09-15 20:06:58 +0000 @@ -1,12 +1,38 @@ package org.hisp.dhis.dataapproval; -import com.fasterxml.jackson.annotation.JsonProperty; -import com.fasterxml.jackson.dataformat.xml.annotation.JacksonXmlRootElement; -import org.hisp.dhis.common.DxfNamespaces; +/* + * Copyright (c) 2004-2014, University of Oslo + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * Redistributions of source code must retain the above copyright notice, this + * list of conditions and the following disclaimer. + * + * Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * Neither the name of the HISP project nor the names of its contributors may + * be used to endorse or promote products derived from this software without + * specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND + * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED + * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR + * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + */ import java.util.ArrayList; import java.util.List; +import com.fasterxml.jackson.annotation.JsonProperty; + public class DataApprovalStateResponses { List<DataApprovalStateResponse> dataApprovalStateResponses = new ArrayList<>(); === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/DataElement.java 2014-09-15 20:06:58 +0000 @@ -150,11 +150,6 @@ private DataElementCategoryCombo categoryCombo; /** - * Defines a custom sort order. - */ - private Integer sortOrder; - - /** * URL for lookup of additional information on the web. */ private String url; @@ -552,16 +547,6 @@ this.categoryCombo = categoryCombo; } - public Integer getSortOrder() - { - return sortOrder; - } - - public void setSortOrder( Integer sortOrder ) - { - this.sortOrder = sortOrder; - } - @JsonProperty @JsonView( { DetailedView.class, ExportView.class } ) @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0 ) @@ -716,7 +701,6 @@ aggregationOperator = dataElement.getAggregationOperator() == null ? aggregationOperator : dataElement .getAggregationOperator(); categoryCombo = dataElement.getCategoryCombo() == null ? categoryCombo : dataElement.getCategoryCombo(); - sortOrder = dataElement.getSortOrder() == null ? sortOrder : dataElement.getSortOrder(); url = dataElement.getUrl() == null ? url : dataElement.getUrl(); optionSet = dataElement.getOptionSet() == null ? optionSet : dataElement.getOptionSet(); === removed file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/comparator/DataElementSortOrderComparator.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/comparator/DataElementSortOrderComparator.java 2014-03-18 08:10:10 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataelement/comparator/DataElementSortOrderComparator.java 1970-01-01 00:00:00 +0000 @@ -1,55 +0,0 @@ -package org.hisp.dhis.dataelement.comparator; - -/* - * Copyright (c) 2004-2014, University of Oslo - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are met: - * Redistributions of source code must retain the above copyright notice, this - * list of conditions and the following disclaimer. - * - * Redistributions in binary form must reproduce the above copyright notice, - * this list of conditions and the following disclaimer in the documentation - * and/or other materials provided with the distribution. - * Neither the name of the HISP project nor the names of its contributors may - * be used to endorse or promote products derived from this software without - * specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE - * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR - * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES - * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; - * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON - * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS - * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - */ - -import java.util.Comparator; - -import org.hisp.dhis.dataelement.DataElement; - -/** - * @author Lars Helge Overland - * @version $Id$ - */ -public class DataElementSortOrderComparator - implements Comparator<DataElement> -{ - public int compare( DataElement dataElement0, DataElement dataElement1 ) - { - if ( dataElement0.getSortOrder() == null || dataElement0.getSortOrder() == 0 ) - { - return dataElement0.getName().compareTo( dataElement1.getName() ); - } - if ( dataElement1.getSortOrder() == null || dataElement1.getSortOrder() == 0 ) - { - return dataElement0.getName().compareTo( dataElement1.getName() ); - } - - return dataElement0.getSortOrder() - dataElement1.getSortOrder(); - } -} === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/DataSet.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/DataSet.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/DataSet.java 2014-09-15 20:06:58 +0000 @@ -131,11 +131,6 @@ private DataElementCategoryCombo categoryCombo; /** - * Indicating position in the custom sort order. - */ - private Integer sortOrder; - - /** * Property indicating if the dataset could be collected using mobile data * entry. */ @@ -608,16 +603,6 @@ this.organisationUnitGroups = organisationUnitGroups; } - public Integer getSortOrder() - { - return sortOrder; - } - - public void setSortOrder( Integer sortOrder ) - { - this.sortOrder = sortOrder; - } - @JsonProperty @JsonSerialize( contentAs = BaseIdentifiableObject.class ) @JsonView( { DetailedView.class, WithoutOrganisationUnitsView.class } ) @@ -893,7 +878,6 @@ DataSet dataSet = (DataSet) other; periodType = dataSet.getPeriodType() == null ? periodType : dataSet.getPeriodType(); - sortOrder = dataSet.getSortOrder() == null ? sortOrder : dataSet.getSortOrder(); mobile = dataSet.isMobile(); dataEntryForm = dataSet.getDataEntryForm() == null ? dataEntryForm : dataSet.getDataEntryForm(); version = dataSet.getVersion() == null ? version : dataSet.getVersion(); === removed file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/comparator/DataSetSortOrderComparator.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/comparator/DataSetSortOrderComparator.java 2014-04-06 11:19:24 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/dataset/comparator/DataSetSortOrderComparator.java 1970-01-01 00:00:00 +0000 @@ -1,55 +0,0 @@ -package org.hisp.dhis.dataset.comparator; - -/* - * Copyright (c) 2004-2014, University of Oslo - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are met: - * Redistributions of source code must retain the above copyright notice, this - * list of conditions and the following disclaimer. - * - * Redistributions in binary form must reproduce the above copyright notice, - * this list of conditions and the following disclaimer in the documentation - * and/or other materials provided with the distribution. - * Neither the name of the HISP project nor the names of its contributors may - * be used to endorse or promote products derived from this software without - * specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE - * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR - * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES - * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; - * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON - * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS - * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - */ - -import java.util.Comparator; - -import org.hisp.dhis.dataset.DataSet; - -/** - * @author Lars Helge Overland - */ -public class DataSetSortOrderComparator - implements Comparator<DataSet> -{ - public int compare( DataSet dataSet0, DataSet dataSet1 ) - { - if ( dataSet0.getSortOrder() == null || dataSet0.getSortOrder() == 0 ) - { - return dataSet0.getName().compareTo( dataSet1.getName() ); - } - - if ( dataSet1.getSortOrder() == null || dataSet1.getSortOrder() == 0 ) - { - return dataSet0.getName().compareTo( dataSet1.getName() ); - } - - return dataSet0.getSortOrder() - dataSet1.getSortOrder(); - } -} === modified file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/Indicator.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/Indicator.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/Indicator.java 2014-09-15 20:06:58 +0000 @@ -77,8 +77,6 @@ private transient String explodedDenominator; - private Integer sortOrder; - private String url; private Set<IndicatorGroup> groups = new HashSet<>(); @@ -271,16 +269,6 @@ this.explodedDenominator = explodedDenominator; } - public Integer getSortOrder() - { - return sortOrder; - } - - public void setSortOrder( Integer sortOrder ) - { - this.sortOrder = sortOrder; - } - @JsonProperty @JsonView( {DetailedView.class, ExportView.class} ) @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0) === removed directory 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/comparator' === removed file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/comparator/IndicatorSortOrderComparator.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/comparator/IndicatorSortOrderComparator.java 2014-03-18 08:10:10 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/indicator/comparator/IndicatorSortOrderComparator.java 1970-01-01 00:00:00 +0000 @@ -1,56 +0,0 @@ -package org.hisp.dhis.indicator.comparator; - -/* - * Copyright (c) 2004-2014, University of Oslo - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are met: - * Redistributions of source code must retain the above copyright notice, this - * list of conditions and the following disclaimer. - * - * Redistributions in binary form must reproduce the above copyright notice, - * this list of conditions and the following disclaimer in the documentation - * and/or other materials provided with the distribution. - * Neither the name of the HISP project nor the names of its contributors may - * be used to endorse or promote products derived from this software without - * specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE - * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR - * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES - * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; - * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON - * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS - * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - */ - -import java.util.Comparator; - -import org.hisp.dhis.indicator.Indicator; - -/** - * @author Lars Helge Overland - * @version $Id$ - */ -public class IndicatorSortOrderComparator - implements Comparator<Indicator> -{ - public int compare( Indicator indicator0, Indicator indicator1 ) - { - if ( indicator0.getSortOrder() == null || indicator0.getSortOrder() == 0 ) - { - return indicator0.getName().compareTo( indicator1.getName() ); - } - - if ( indicator1.getSortOrder() == null || indicator1.getSortOrder() == 0 ) - { - return indicator0.getName().compareTo( indicator1.getName() ); - } - - return indicator0.getSortOrder() - indicator1.getSortOrder(); - } -} === removed file 'dhis-2/dhis-api/src/main/java/org/hisp/dhis/program/comparator/ProgramStageDataElementSortOrderComparator.java' --- dhis-2/dhis-api/src/main/java/org/hisp/dhis/program/comparator/ProgramStageDataElementSortOrderComparator.java 2014-05-23 15:28:46 +0000 +++ dhis-2/dhis-api/src/main/java/org/hisp/dhis/program/comparator/ProgramStageDataElementSortOrderComparator.java 1970-01-01 00:00:00 +0000 @@ -1,48 +0,0 @@ -package org.hisp.dhis.program.comparator; - -/* - * Copyright (c) 2004-2014, University of Oslo - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are met: - * Redistributions of source code must retain the above copyright notice, this - * list of conditions and the following disclaimer. - * - * Redistributions in binary form must reproduce the above copyright notice, - * this list of conditions and the following disclaimer in the documentation - * and/or other materials provided with the distribution. - * Neither the name of the HISP project nor the names of its contributors may - * be used to endorse or promote products derived from this software without - * specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND - * ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED - * WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE - * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR - * ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES - * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; - * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON - * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT - * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS - * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - */ - -import org.hisp.dhis.program.ProgramStageDataElement; - -import java.util.Comparator; - -public class ProgramStageDataElementSortOrderComparator - implements Comparator<ProgramStageDataElement> -{ - @Override - public int compare( ProgramStageDataElement object0, ProgramStageDataElement object1 ) - { - if ( object0.getDataElement().getSortOrder() == null ) - { - return object1.getDataElement().getSortOrder() != null ? -1 : 0; - } - - return object0.getDataElement().getSortOrder().compareTo( object1.getDataElement().getSortOrder() ); - } -} === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/startup/TableAlteror.java' --- dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/startup/TableAlteror.java 2014-09-10 14:53:21 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/java/org/hisp/dhis/startup/TableAlteror.java 2014-09-15 20:06:58 +0000 @@ -732,6 +732,10 @@ executeSql( "alter table expression alter column missingvaluestrategy set not null" ); executeSql( "alter table expression drop column nullifblank" ); + executeSql( "alter table dataelement drop column sortorder" ); + executeSql( "alter table indicator drop column sortorder" ); + executeSql( "alter table dataset drop column sortorder" ); + upgradeDataValuesWithAttributeOptionCombo(); upgradeCompleteDataSetRegistrationsWithAttributeOptionCombo(); upgradeMapViewsToAnalyticalObject(); === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataelement/hibernate/DataElement.hbm.xml' --- dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataelement/hibernate/DataElement.hbm.xml 2014-06-26 09:29:30 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataelement/hibernate/DataElement.hbm.xml 2014-09-15 20:06:58 +0000 @@ -36,8 +36,6 @@ column="categorycomboid" foreign-key="fk_dataelement_categorycomboid" /> - <property name="sortOrder" /> - <property name="url" /> <set name="groups" table="dataelementgroupmembers" inverse="true"> === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataset/hibernate/DataSet.hbm.xml' --- dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataset/hibernate/DataSet.hbm.xml 2014-01-23 11:54:46 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/dataset/hibernate/DataSet.hbm.xml 2014-09-15 20:06:58 +0000 @@ -65,8 +65,6 @@ column="categorycomboid" foreign-key="fk_dataset_categorycomboid" /> - <property name="sortOrder" /> - <many-to-one name="dataEntryForm" class="org.hisp.dhis.dataentryform.DataEntryForm" foreign-key="fk_dataset_dataentryform" cascade="all" /> === modified file 'dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/indicator/hibernate/Indicator.hbm.xml' --- dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/indicator/hibernate/Indicator.hbm.xml 2013-02-07 10:25:34 +0000 +++ dhis-2/dhis-services/dhis-service-core/src/main/resources/org/hisp/dhis/indicator/hibernate/Indicator.hbm.xml 2014-09-15 20:06:58 +0000 @@ -34,8 +34,6 @@ <property name="denominatorDescription" column="denominatordescription" type="text" /> - <property name="sortOrder" /> - <property name="url" /> <set name="groups" table="indicatorgroupmembers" inverse="true"> === modified file 'dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/file/rowhandler/CaculatedDataElementRowHandler.java' --- dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/file/rowhandler/CaculatedDataElementRowHandler.java 2014-03-18 08:10:10 +0000 +++ dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/file/rowhandler/CaculatedDataElementRowHandler.java 2014-09-15 20:06:58 +0000 @@ -94,7 +94,6 @@ indicator.setShortName( dhis14CalcDE.getDataElementShort() ); indicator.setDescription( dhis14CalcDE.getDataElementDescription() ); indicator.getIndicatorType().setId( 1151589 ); - indicator.setSortOrder( dhis14CalcDE.getSortOrder() ); indicator.setLastUpdated( dhis14CalcDE.getLastUpdated() ); indicator.setUid( dhis14CalcDE.getUid() ); === modified file 'dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/xml/converter/DataElementConverter.java' --- dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/xml/converter/DataElementConverter.java 2014-06-26 09:29:30 +0000 +++ dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/xml/converter/DataElementConverter.java 2014-09-15 20:06:58 +0000 @@ -28,6 +28,15 @@ * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +import static org.hisp.dhis.dataelement.DataElementCategoryCombo.DEFAULT_CATEGORY_COMBO_NAME; +import static org.hisp.dhis.importexport.dhis14.util.Dhis14TypeHandler.convertAggregationOperatorFromDhis14; +import static org.hisp.dhis.importexport.dhis14.util.Dhis14TypeHandler.convertAggregationOperatorToDhis14; +import static org.hisp.dhis.importexport.dhis14.util.Dhis14TypeHandler.convertBooleanToDhis14; +import static org.hisp.dhis.importexport.dhis14.util.Dhis14TypeHandler.convertTypeToDhis14; + +import java.util.Collection; +import java.util.Map; + import org.amplecode.staxwax.reader.XMLReader; import org.amplecode.staxwax.writer.XMLWriter; import org.hisp.dhis.dataelement.DataElement; @@ -46,13 +55,6 @@ import org.hisp.dhis.importexport.importer.DataElementImporter; import org.hisp.dhis.importexport.mapping.NameMappingUtil; -import java.util.Collection; -import java.util.Map; - -import static org.hisp.dhis.dataelement.DataElementCategoryCombo.DEFAULT_CATEGORY_COMBO_NAME; -import static org.hisp.dhis.importexport.dhis14.util.Dhis14TypeHandler.*; -import static org.hisp.dhis.system.util.ConversionUtils.parseInt; - /** * @author Lars Helge Overland * @version $Id: DataElementConverter.java 6455 2008-11-24 08:59:37Z larshelg $ @@ -67,8 +69,6 @@ private static final String FIELD_UID = "DataElementCode"; - private static final String FIELD_SORT_ORDER = "SortOrder"; - private static final String FIELD_NAME = "DataElementName"; private static final String FIELD_SHORT_NAME = "DataElementShort"; @@ -196,7 +196,6 @@ if ( elements != null && elements.size() > 0 ) { - int i = 0; for ( DataElement object : elements ) { String name = object.getName(); @@ -208,8 +207,6 @@ writer.openElement( ELEMENT_NAME ); writer.writeElement( FIELD_ID, String.valueOf( object.getId() ) ); - writer.writeElement( FIELD_SORT_ORDER, - object.getSortOrder() != null ? String.valueOf( object.getSortOrder() ) : String.valueOf( i++ ) ); writer.writeElement( FIELD_UID, object.getUid() ); writer.writeElement( FIELD_NAME, name ); writer.writeElement( FIELD_SHORT_NAME, shortName ); @@ -281,7 +278,6 @@ Integer.parseInt( values.get( FIELD_DATA_TYPE ) ) ) ); element .setAggregationOperator( convertAggregationOperatorFromDhis14( values.get( FIELD_AGGREGATION_OPERATOR ) ) ); - element.setSortOrder( parseInt( values.get( FIELD_SORT_ORDER ) ) ); element.setLastUpdated( Dhis14DateUtil.getDate( values.get( FIELD_LAST_UPDATED ) ) ); if ( values.get( FIELD_CALCULATED ).equals( "0" ) ) // Ignore calculated === modified file 'dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/xml/converter/IndicatorConverter.java' --- dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/xml/converter/IndicatorConverter.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-services/dhis-service-importexport/src/main/java/org/hisp/dhis/importexport/dhis14/xml/converter/IndicatorConverter.java 2014-09-15 20:06:58 +0000 @@ -31,7 +31,6 @@ import static org.hisp.dhis.importexport.dhis14.util.Dhis14ExpressionConverter.convertExpressionFromDhis14; import static org.hisp.dhis.importexport.dhis14.util.Dhis14ExpressionConverter.convertExpressionToDhis14; import static org.hisp.dhis.importexport.dhis14.util.Dhis14TypeHandler.convertBooleanFromDhis14; -import static org.hisp.dhis.system.util.ConversionUtils.parseInt; import java.util.Collection; import java.util.Map; @@ -64,7 +63,6 @@ public static final String ELEMENT_NAME = "Indicator"; private static final String FIELD_ID = "IndicatorID"; - private static final String FIELD_SORT_ORDER = "SortOrder"; private static final String FIELD_NAME = "IndicatorName"; private static final String FIELD_SHORT_NAME = "IndicatorShort"; private static final String FIELD_DOS = "IndicatorDOS"; @@ -147,7 +145,6 @@ writer.openElement( ELEMENT_NAME ); writer.writeElement( FIELD_ID, String.valueOf( object.getId() ) ); - writer.writeElement( FIELD_SORT_ORDER, object.getSortOrder() != null ? String.valueOf( object.getSortOrder() ) : EMPTY ); writer.writeElement( FIELD_NAME, object.getName() ); writer.writeElement( FIELD_SHORT_NAME, object.getShortName() ); writer.writeElement( FIELD_DOS, TextUtils.subString( object.getShortName(), 0, 8 ) ); @@ -195,7 +192,6 @@ indicator.setNumerator( convertExpressionFromDhis14( values.get( FIELD_NUMERATOR ), dataElementMapping, categoryOptionCombo.getId(), indicator.getName() ) ); indicator.setDenominator( convertExpressionFromDhis14( values.get( FIELD_DENOMINATOR ), dataElementMapping, categoryOptionCombo.getId(), indicator.getName() ) ); - indicator.setSortOrder( parseInt( values.get( FIELD_SORT_ORDER ) ) ); indicator.setLastUpdated( Dhis14DateUtil.getDate( values.get( FIELD_LAST_UPDATED ) ) ); importObject( indicator, params ); === modified file 'dhis-2/dhis-services/dhis-service-mobile/src/main/java/org/hisp/dhis/mobile/service/ActivityReportingServiceImpl.java' --- dhis-2/dhis-services/dhis-service-mobile/src/main/java/org/hisp/dhis/mobile/service/ActivityReportingServiceImpl.java 2014-09-13 16:17:05 +0000 +++ dhis-2/dhis-services/dhis-service-mobile/src/main/java/org/hisp/dhis/mobile/service/ActivityReportingServiceImpl.java 2014-09-15 20:06:58 +0000 @@ -1311,19 +1311,6 @@ return anonymousProgramMobile; } - private List<TrackedEntityInstance> removeIfDuplicated( List<TrackedEntityInstance> patients, int patientId ) - { - List<TrackedEntityInstance> result = new ArrayList<>( patients ); - for ( int i = 0; i < patients.size(); i++ ) - { - if ( patients.get( i ).getId() == patientId ) - { - result.remove( i ); - } - } - return result; - } - private void saveDataValues( ActivityValue activityValue, ProgramStageInstance programStageInstance, Map<Integer, DataElement> dataElementMap ) { === modified file 'dhis-2/dhis-services/dhis-service-mobile/src/main/java/org/hisp/dhis/mobile/service/FacilityReportingServiceImpl.java' --- dhis-2/dhis-services/dhis-service-mobile/src/main/java/org/hisp/dhis/mobile/service/FacilityReportingServiceImpl.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-services/dhis-service-mobile/src/main/java/org/hisp/dhis/mobile/service/FacilityReportingServiceImpl.java 2014-09-15 20:06:58 +0000 @@ -56,7 +56,6 @@ import org.hisp.dhis.api.mobile.model.Section; import org.hisp.dhis.dataelement.DataElementCategoryOptionCombo; import org.hisp.dhis.dataelement.DataElementOperand; -import org.hisp.dhis.dataelement.comparator.DataElementSortOrderComparator; import org.hisp.dhis.dataset.CompleteDataSetRegistration; import org.hisp.dhis.dataset.CompleteDataSetRegistrationService; import org.hisp.dhis.organisationunit.OrganisationUnit; @@ -80,8 +79,6 @@ private static boolean DEBUG = log.isDebugEnabled(); - private DataElementSortOrderComparator dataElementComparator = new DataElementSortOrderComparator(); - // ------------------------------------------------------------------------- // Dependencies // ------------------------------------------------------------------------- @@ -264,8 +261,6 @@ List<org.hisp.dhis.dataelement.DataElement> dataElements = new ArrayList<>( dataSet.getDataElements() ); - Collections.sort( dataElements, dataElementComparator ); - // Fake section to store data elements Section section = new Section(); === modified file 'dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/DataElementBatchHandler.java' --- dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/DataElementBatchHandler.java 2014-06-26 09:29:30 +0000 +++ dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/DataElementBatchHandler.java 2014-09-15 20:06:58 +0000 @@ -100,7 +100,6 @@ statementBuilder.setColumn( "domaintype" ); statementBuilder.setColumn( "aggregationtype" ); statementBuilder.setColumn( "categorycomboid" ); - statementBuilder.setColumn( "sortorder" ); statementBuilder.setColumn( "zeroissignificant" ); } @@ -115,7 +114,6 @@ statementBuilder.setValue( dataElement.getDomainType().name() ); statementBuilder.setValue( dataElement.getAggregationOperator() ); statementBuilder.setValue( dataElement.getCategoryCombo().getId() ); - statementBuilder.setValue( dataElement.getSortOrder() ); statementBuilder.setValue( dataElement.isZeroIsSignificant() ); } } === modified file 'dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/DataSetBatchHandler.java' --- dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/DataSetBatchHandler.java 2014-03-18 08:10:10 +0000 +++ dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/DataSetBatchHandler.java 2014-09-15 20:06:58 +0000 @@ -96,7 +96,6 @@ statementBuilder.setColumn( "shortname" ); statementBuilder.setColumn( "code" ); statementBuilder.setColumn( "periodtypeid" ); - statementBuilder.setColumn( "sortorder" ); statementBuilder.setColumn( "mobile" ); statementBuilder.setColumn( "allowfutureperiods" ); statementBuilder.setColumn( "dataentryform" ); @@ -121,7 +120,6 @@ statementBuilder.setValue( dataSet.getShortName() ); statementBuilder.setValue( dataSet.getCode() ); statementBuilder.setValue( dataSet.getPeriodType().getId() ); - statementBuilder.setValue( dataSet.getSortOrder() ); statementBuilder.setValue( dataSet.isMobile() ); statementBuilder.setValue( dataSet.isAllowFuturePeriods() ); statementBuilder.setValue( dataSet.getDataEntryForm() != null ? dataSet.getDataEntryForm().getId() : null ); === modified file 'dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/IndicatorBatchHandler.java' --- dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/IndicatorBatchHandler.java 2014-03-18 08:10:10 +0000 +++ dhis-2/dhis-support/dhis-support-jdbc/src/main/java/org/hisp/dhis/jdbc/batchhandler/IndicatorBatchHandler.java 2014-09-15 20:06:58 +0000 @@ -102,7 +102,6 @@ statementBuilder.setColumn( "numeratordescription" ); statementBuilder.setColumn( "denominator" ); statementBuilder.setColumn( "denominatordescription" ); - statementBuilder.setColumn( "sortorder" ); } protected void setValues( Indicator indicator ) @@ -118,6 +117,5 @@ statementBuilder.setValue( indicator.getNumeratorDescription() ); statementBuilder.setValue( indicator.getDenominator() ); statementBuilder.setValue( indicator.getDenominatorDescription() ); - statementBuilder.setValue( indicator.getSortOrder() ); } } === modified file 'dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/utils/FormUtils.java' --- dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/utils/FormUtils.java 2014-08-13 10:40:43 +0000 +++ dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/utils/FormUtils.java 2014-09-15 20:06:58 +0000 @@ -227,7 +227,6 @@ field.setDataElement( dataElement.getUid() ); field.setCategoryOptionCombo( categoryOptionCombo.getUid() ); field.setType( inputTypeFromDataElement( dataElement ) ); - field.setSortOrder( dataElement.getSortOrder() ); if ( dataElement.getOptionSet() != null ) { === modified file 'dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/webdomain/form/Field.java' --- dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/webdomain/form/Field.java 2014-07-09 01:44:58 +0000 +++ dhis-2/dhis-web/dhis-web-api/src/main/java/org/hisp/dhis/webapi/webdomain/form/Field.java 2014-09-15 20:06:58 +0000 @@ -51,8 +51,6 @@ private String optionSet; - private Integer sortOrder; - public Field() { } @@ -128,16 +126,4 @@ { this.optionSet = optionSet; } - - @JsonProperty - @JacksonXmlProperty( namespace = DxfNamespaces.DXF_2_0 ) - public Integer getSortOrder() - { - return sortOrder; - } - - public void setSortOrder( Integer sortOrder ) - { - this.sortOrder = sortOrder; - } } === modified file 'dhis-2/dhis-web/dhis-web-caseentry/src/main/java/org/hisp/dhis/caseentry/action/caseentry/LoadDataEntryAction.java' --- dhis-2/dhis-web/dhis-web-caseentry/src/main/java/org/hisp/dhis/caseentry/action/caseentry/LoadDataEntryAction.java 2014-08-29 12:48:40 +0000 +++ dhis-2/dhis-web/dhis-web-caseentry/src/main/java/org/hisp/dhis/caseentry/action/caseentry/LoadDataEntryAction.java 2014-09-15 20:06:58 +0000 @@ -52,7 +52,6 @@ import org.hisp.dhis.program.ProgramStageInstanceService; import org.hisp.dhis.program.ProgramStageSection; import org.hisp.dhis.program.ProgramStageService; -import org.hisp.dhis.program.comparator.ProgramStageDataElementSortOrderComparator; import org.hisp.dhis.program.comparator.ProgramStageSectionSortOrderComparator; import org.hisp.dhis.trackedentity.TrackedEntityInstance; import org.hisp.dhis.trackedentitydatavalue.TrackedEntityDataValue; @@ -296,7 +295,6 @@ // --------------------------------------------------------------------- programStageDataElements = new ArrayList<>( programStage.getProgramStageDataElements() ); - Collections.sort( programStageDataElements, new ProgramStageDataElementSortOrderComparator() ); DataEntryForm dataEntryForm = programStage.getDataEntryForm(); === modified file 'dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-mobile/src/main/java/org/hisp/dhis/mobile/action/smscommand/SMSCommandAction.java' --- dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-mobile/src/main/java/org/hisp/dhis/mobile/action/smscommand/SMSCommandAction.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-web/dhis-web-maintenance/dhis-web-maintenance-mobile/src/main/java/org/hisp/dhis/mobile/action/smscommand/SMSCommandAction.java 2014-09-15 20:06:58 +0000 @@ -30,13 +30,11 @@ import java.util.ArrayList; import java.util.Collection; -import java.util.Collections; import java.util.HashMap; import java.util.List; import java.util.Map; import org.hisp.dhis.dataelement.DataElement; -import org.hisp.dhis.dataelement.comparator.DataElementSortOrderComparator; import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.DataSetService; import org.hisp.dhis.program.Program; @@ -190,7 +188,6 @@ if ( d != null ) { dataElements = new ArrayList<>( d.getDataElements() ); - Collections.sort( dataElements, new DataElementSortOrderComparator() ); return dataElements; } } === modified file 'dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/GetFilteredDataElementsAction.java' --- dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/GetFilteredDataElementsAction.java 2014-08-15 07:40:20 +0000 +++ dhis-2/dhis-web/dhis-web-validationrule/src/main/java/org/hisp/dhis/validationrule/action/GetFilteredDataElementsAction.java 2014-09-15 20:06:58 +0000 @@ -42,7 +42,6 @@ import org.hisp.dhis.dataelement.DataElementOperand; import org.hisp.dhis.dataset.DataSet; import org.hisp.dhis.dataset.DataSetService; -import org.hisp.dhis.dataset.comparator.DataSetSortOrderComparator; import org.hisp.dhis.period.PeriodService; import org.hisp.dhis.period.PeriodType; @@ -153,8 +152,8 @@ List<DataSet> dataSets = new ArrayList<>( dataSetService.getDataSetsByPeriodType( periodType ) ); - Collections.sort( dataSets, new DataSetSortOrderComparator() ); - + Collections.sort( dataSets, IdentifiableObjectNameComparator.INSTANCE ); + // ----------------------------------------------------------------- // Get available dataelements into the dataSets // -----------------------------------------------------------------
_______________________________________________ Mailing list: https://launchpad.net/~dhis2-devs Post to : dhis2-devs@lists.launchpad.net Unsubscribe : https://launchpad.net/~dhis2-devs More help : https://help.launchpad.net/ListHelp