Fundamentally, on all platforms it allocates an area, then protects a part of it, and eventually deallocates. The specific OS API differs, but that's what I want to abstract away into a small platform-specific section, so that rest of it would be platform-agnostic. I guess I now have an excuse to get that arm64 Mac :)
I'm all for good developer experience :) The Valgrind, ASAN and TSAN hooks would be unaffected. Cheers, Kuba On Wednesday, June 28, 2023 at 1:55:17 PM UTC-4 j...@craftyjon.com wrote: > I'm not clear on how all platforms can take the same codepath since there > is some fundamentally platform-specific code in here? > > Anyway, my own personal thoughts are that anyone looking to work on this > area: > > 1) should be prepared to do their own testing on at least Windows + arm64 > Mac + amd64 Linux > 2) should pay careful attention to not degrading the developer experience: > we already have some pain here around debuggers and sanitizers, and we want > to at least not make it worse than it is today. > > -Jon > > On Wed, Jun 28, 2023 at 1:32 PM 'Kuba Sunderland-Ober' via KiCad > Developers <dev...@kicad.org> wrote: > >> I ran across COROUTINE and noted that it could be cleaned up, and guard >> pages could be supported on all platforms too. >> >> Would that be something worth doing? I experimented with custom deleters >> for the m_stack pointer and they seem to make things less verbose and >> should make all platforms take the same code path, adapted for various >> incarnations of mmap/virtualalloc/virtualprotect without treating Windows >> specially. >> >> Cheers, Kuba >> >> -- >> You received this message because you are subscribed to the Google Groups >> "KiCad Developers" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to devlist+u...@kicad.org. >> To view this discussion on the web visit >> https://groups.google.com/a/kicad.org/d/msgid/devlist/3d093521-5ed0-42af-94db-265485e6474an%40kicad.org >> >> <https://groups.google.com/a/kicad.org/d/msgid/devlist/3d093521-5ed0-42af-94db-265485e6474an%40kicad.org?utm_medium=email&utm_source=footer> >> . >> > -- You received this message because you are subscribed to the Google Groups "KiCad Developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to devlist+unsubscr...@kicad.org. To view this discussion on the web visit https://groups.google.com/a/kicad.org/d/msgid/devlist/b732f487-1c53-4710-9866-3413a8ba45fdn%40kicad.org.
