On 28.11.2017 19:13, Waldemar Brodkorb wrote:
Hi,
Ronald Wahl wrote,
On 28.11.2017 19:03, Waldemar Brodkorb wrote:
Ronald Wahl wrote,
just tried updating to uclibc-ng 1.0.27 and now I get the following
during build:
build-for-target/libc/libc_so.a(w_j0.os): In function `j0':
./uclibc-ng/libm/w_j0.c:34: undefined reference to `__ieee754_j0'
build-for-target/libc/libc_so.a(w_j0.os): In function `y0':
./uclibc-ng/libm/w_j0.c:62: undefined reference to `__ieee754_y0'
build-for-target/libc/libc_so.a(w_j0f.os): In function `y0f':
./uclibc-ng/libm/w_j0f.c:66: undefined reference to `__ieee754_y0f'
build-for-target/libc/libc_so.a(w_j1.os): In function `j1':
./uclibc-ng/libm/w_j1.c:35: undefined reference to `__ieee754_j1'
build-for-target/libc/libc_so.a(w_j1.os): In function `y1':
./uclibc-ng/libm/w_j1.c:63: undefined reference to `__ieee754_y1'
build-for-target/libc/libc_so.a(w_jn.os): In function `jn':
./uclibc-ng/libm/w_jn.c:34: undefined reference to `__ieee754_jn'
build-for-target/libc/libc_so.a(w_jn.os): In function `yn':
./uclibc-ng/libm/w_jn.c:62: undefined reference to `__ieee754_yn'
This is because I have DO_XSI_MATH disabled and commit
ea38f4d89c9698895b1cf53a5946429dc1d8bbaa added a lot of files to compile
unconditionally that use functions only enabled with DO_XSI_MATH.
Thanks for the bug report Ronald.
Sergey, you contributed the math rework patch, could you have a
look?
Conditionally compiling the files
w_j0.c w_j0f.c w_j0l.c
w_j1.c w_j1f.c w_j1l.c
w_jn.c w_jnf.c w_jnl.c
seems to be enough. Not sure if DO_C99_MATH needs to be set as well.
DO_XSI_MATH and DO_C99_MATH do not depend on each other.
Could you sent a patch for that?
Patch attached.
- ron
--
Raritan Deutschland GmbH, Kornmarkt 7, 08056 Zwickau, Germany
Amtsgericht Chemnitz HRB 23605, Geschäftsführung: Ralf Ploenes
________________________________
Ce message, ainsi que tous les fichiers joints à ce message, peuvent contenir
des informations sensibles et/ ou confidentielles ne devant pas être
divulguées. Si vous n'êtes pas le destinataire de ce message (ou que vous
recevez ce message par erreur), nous vous remercions de le notifier
immédiatement à son expéditeur, et de détruire ce message. Toute copie,
divulgation, modification, utilisation ou diffusion, non autorisée, directe ou
indirecte, de tout ou partie de ce message, est strictement interdite.
This e-mail, and any document attached hereby, may contain confidential and/or
privileged information. If you are not the intended recipient (or have received
this e-mail in error) please notify the sender immediately and destroy this
e-mail. Any unauthorized, direct or indirect, copying, disclosure, distribution
or other use of the material or parts thereof is strictly forbidden.
>From 2facfc8f81924e45f0eeff377a0b8fedb1497211 Mon Sep 17 00:00:00 2001
From: Ronald Wahl <ronald.w...@raritan.com>
Date: Tue, 28 Nov 2017 19:20:45 +0100
Subject: [PATCH] [math] Fix build regression with DO_XSI_MATH disabled
Commit ea38f4d89 (math: add exception handling functionality) adds a
regression so that build configurations that have DO_C99_MATH enabled
and DO_XSI_MATH disabled will not link. This commit moves the files with
the bessel functions from DO_C99_MATH to DO_XSI_MATH. It looks like they
are not even contained in C99.
Signed-off-by: Ronald Wahl <ronald.w...@raritan.com>
---
libm/Makefile.in | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/libm/Makefile.in b/libm/Makefile.in
index e2f4ff808..4e468d4ba 100644
--- a/libm/Makefile.in
+++ b/libm/Makefile.in
@@ -74,9 +74,6 @@ libm_CSRC := \
w_exp.c w_expf.c w_expl.c \
w_exp2.c w_exp2f.c w_exp2l.c \
w_exp10.c w_exp10f.c w_exp10l.c \
- w_j0.c w_j0f.c w_j0l.c \
- w_j1.c w_j1f.c w_j1l.c \
- w_jn.c w_jnf.c w_jnl.c \
w_lgamma_r.c w_lgammaf_r.c w_lgammal_r.c \
w_lgamma.c w_lgammaf.c w_lgammal.c \
w_tgamma.c w_tgammaf.c w_tgammal.c \
@@ -267,7 +264,11 @@ FL_MOBJ := sqrtf.o
endif
ifeq ($(DO_XSI_MATH),y)
-libm_CSRC += e_j0.c e_j1.c e_jn.c
+libm_CSRC += \
+ e_j0.c e_j1.c e_jn.c \
+ w_j0.c w_j0f.c w_j0l.c \
+ w_j1.c w_j1f.c w_j1l.c \
+ w_jn.c w_jnf.c w_jnl.c
endif
# assume that arch specific versions are provided as single sources/objects
--
2.13.6
_______________________________________________
devel mailing list
devel@uclibc-ng.org
https://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
