Hi, Vineet Gupta wrote, > On 08/20/2017 03:54 AM, Waldemar Brodkorb wrote: > >Hi Alexey, > >Alexey Brodkin wrote, > > > >>In cde74b83f9b2 "ARC: remove special CFLAGS/LDFLAGS handling" we > >>got rid of CONFIG_ARC_CPU_HS which was used to select ARCv2-specific > >>implementation of optimized string routines. So now ARCv2-tuned > >>memset/memcpy/strcmp are not used, instead those for ARC700 used for > >>both ARC700 and ARCHS. > >> > >>Without uClibc config option we may only tell which CPU type we're > >>targeting by built-in defines of GCC. I.e. no more conditional file > >>inclusion in Makefiles. That leaves us only one option - merge both > >>implementations in 1 file and use ifdefs. > >> > >>Signed-off-by: Alexey Brodkin <abrod...@synopsys.com> > >Thanks, applied and pushed. > > > >best regards > > Waldemar > > > Aah too late to chime - but is this really the right / elegant solution. > I would rather have reintroduced the Kconfig optino for this ?
It is never too late. We could revert the commit if there is consense. I like the solution and do not want to reintroduce Kconfig options for any subarch stuff. We removed mips64 abi stuff and CFLAGS in the same way we have done for arc. I like the way, that we use toolchain defaults to compile the correct code without forcing the user to provide a correct config for uClibc. best regards Waldemar _______________________________________________ devel mailing list devel@uclibc-ng.org https://mailman.uclibc-ng.org/cgi-bin/mailman/listinfo/devel
