On 08.11.18 20:08, [email protected] wrote:
>> Following patch seems to fix the issue. Can you please have a look and
>> verify that it is correct ? Or should it be solved on another place in
>> the kernel differently.
> 
> Yes, the patch is correct and definitely fixes a bug. Thanks! Would you like 
> me to apply this directly or will you raise a PR? In order to not cause 
> unneccessary headaches for verification, I would undo the convert to switch 
> and leave the statement as an if. 

You may apply directly.

Regarding the switch change, I didn't see an obvious way to keep the
original if statement and add a || and a ifdef CONFIG_VTX ... without
changing the original code. Since the type of switch style and the ifdef
was used already in the same file, I supposed it such be fine.

But let's see how you change it ;-)

Thanks,

-- 
Alexander Boettcher
Genode Labs

https://www.genode-labs.com - https://www.genode.org

Genode Labs GmbH - Amtsgericht Dresden - HRB 28424 - Sitz Dresden
Geschäftsführer: Dr.-Ing. Norman Feske, Christian Helmuth

_______________________________________________
Devel mailing list
[email protected]
https://sel4.systems/lists/listinfo/devel

Reply via email to