Hello! On Thu, Jan 18, 2024 at 4:38 PM Kui Liu <kui....@acronis.com> code wrote: > Is this a mistake that the condition for kmalloc should be "nsplices > 8 * 4” > ?
It should. Unfortunately, the mistake was in wrong direction, so that it had no chances to be noticed, thank you! :-) > Is it difficult to separate the verification of inputs, such as fds, size of > src buffs against dest buffs etc, from the process of copying data? Similar > to what’s been done in ‘copy_out_args()’. I am not sure I understand what you mean here. Show, plz. Do you really think copy_out_args is even "readable"? :-) From my pov it is awful. Actually, I hold 4d patch in series which replaces copy_out_args with normal human intellibible function which copies data 10% faster. And I do not think it was by accident, ugly code is usually a bad code. _______________________________________________ Devel mailing list Devel@openvz.org https://lists.openvz.org/mailman/listinfo/devel
