Hello!

On Wed, Apr 19, 2023 at 3:14 PM Kui Liu <kui....@acronis.com> wrote:
> How about use WARN_ONCE()  just in case to catch any unexpected changes in 
> the future?

For now it is completely our internal thing. We could even drop iter
at all to avoid any surprizes.
But this would be not reasonable, see below.

> BTW, do you think we need to replace iov_iter_get_pages() in 
> do_recv_one_seg() with similar implementation?

No, we do not pass the result anywhere.

Yet we could try to live more dangerously and efficiently. Network
might be ready to accept
generic iter, we could use  sock_recvmsg() instead of spltting it to
multiple kernel_recvmsg,
which could make this code more efficient. It is to be measured
though, profit could be not enough.
Also I have no idea who uses this path, it might be just broken.

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to