From: Peter Zijlstra <pet...@infradead.org>

Extract lockdep_assert{,_once}() helpers to more easily write composite
assertions like, for example:

        lockdep_assert(lockdep_is_held(&drm_device.master_mutex) ||
                       lockdep_is_held(&drm_file.master_lookup_lock));

Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org>
Signed-off-by: Desmond Cheong Zhi Xi <desmondcheon...@gmail.com>
Acked-by: Boqun Feng <boqun.f...@gmail.com>
Acked-by: Waiman Long <long...@redhat.com>
Acked-by: Peter Zijlstra (Intel) <pet...@infradead.org>
Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch>
Link: 
https://patchwork.freedesktop.org/patch/msgid/20210802105957.77692-2-desmondcheon...@gmail.com

(cherry picked from ms commit d19c81378829e5d774c951219c5a973965b9202c)
Signed-off-by: Konstantin Khorenko <khore...@virtuozzo.com>

Backport notes:
  * lockdep_assert_none_held_once() in ms patch does not exist in vz7
    kernel
  * lockdep_assert_held_write() still is named as 
lockdep_assert_held_exclusive()
---
 include/linux/lockdep.h | 36 +++++++++++++++++++-----------------
 1 file changed, 19 insertions(+), 17 deletions(-)

diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h
index 208a9a11de90..97a1753de192 100644
--- a/include/linux/lockdep.h
+++ b/include/linux/lockdep.h
@@ -372,27 +372,26 @@ extern void lockdep_trace_alloc(gfp_t mask);
 
 #define lockdep_depth(tsk)     (debug_locks ? (tsk)->lockdep_depth : 0)
 
-#define lockdep_assert_held(l) do {                                    \
-               WARN_ON(debug_locks &&                                  \
-                       lockdep_is_held(l) == LOCK_STATE_NOT_HELD);     \
-       } while (0)
+#define lockdep_assert(cond)           \
+       do { WARN_ON(debug_locks && !(cond)); } while (0)
 
-#define lockdep_assert_not_held(l)     do {                            \
-               WARN_ON(debug_locks &&                                  \
-                       lockdep_is_held(l) == LOCK_STATE_HELD);         \
-       } while (0)
+#define lockdep_assert_once(cond)      \
+       do { WARN_ON_ONCE(debug_locks && !(cond)); } while (0)
 
-#define lockdep_assert_held_exclusive(l)       do {                    \
-               WARN_ON(debug_locks && !lockdep_is_held_type(l, 0));    \
-       } while (0)
+#define lockdep_assert_held(l)         \
+       lockdep_assert(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
 
-#define lockdep_assert_held_read(l)    do {                            \
-               WARN_ON(debug_locks && !lockdep_is_held_type(l, 1));    \
-       } while (0)
+#define lockdep_assert_not_held(l)     \
+       lockdep_assert(lockdep_is_held(l) != LOCK_STATE_HELD)
 
-#define lockdep_assert_held_once(l)    do {                            \
-               WARN_ON_ONCE(debug_locks && !lockdep_is_held(l));       \
-       } while (0)
+#define lockdep_assert_held_exclusive(l)       \
+       lockdep_assert(lockdep_is_held_type(l, 0))
+
+#define lockdep_assert_held_read(l)    \
+       lockdep_assert(lockdep_is_held_type(l, 1))
+
+#define lockdep_assert_held_once(l)            \
+       lockdep_assert_once(lockdep_is_held(l) != LOCK_STATE_NOT_HELD)
 
 #define lockdep_recursing(tsk) ((tsk)->lockdep_recursion)
 
@@ -445,6 +444,9 @@ struct lock_class_key { };
 
 #define lockdep_is_held_type(l, r)             (1)
 
+#define lockdep_assert(c)                      do { } while (0)
+#define lockdep_assert_once(c)                 do { } while (0)
+
 #define lockdep_assert_held(l)                 do { (void)(l); } while (0)
 #define lockdep_assert_not_held(l)             do { (void)(l); } while (0)
 #define lockdep_assert_held_exclusive(l)       do { (void)(l); } while (0)
-- 
2.24.3

_______________________________________________
Devel mailing list
Devel@openvz.org
https://lists.openvz.org/mailman/listinfo/devel

Reply via email to