On Wed, 2012-01-11 at 13:33 -0500, Trond Myklebust wrote: > On Tue, 2012-01-10 at 17:04 +0400, Stanislav Kinsbursky wrote: > > This is a cleanup patch. We don't need this reference anymore, because > > blocklayout pipes dentries now creates and destroys in per-net operations > > and > > on PipeFS mount/umount notification. > > Note that nfs4blocklayout_register_net() now returns 0 instead of -ENOENT in > > case of PipeFS superblock absence. This is ok, because blocklayout pipe > > dentry > > will be created on PipeFS mount event. > > > > Signed-off-by: Stanislav Kinsbursky <skinsbur...@parallels.com> > > > > --- > > fs/nfs/blocklayout/blocklayout.c | 9 +-------- > > 1 files changed, 1 insertions(+), 8 deletions(-) > > > > diff --git a/fs/nfs/blocklayout/blocklayout.c > > b/fs/nfs/blocklayout/blocklayout.c > > index 322d920..2c70202 100644 > > --- a/fs/nfs/blocklayout/blocklayout.c > > +++ b/fs/nfs/blocklayout/blocklayout.c > > @@ -1034,7 +1034,7 @@ static struct dentry > > *nfs4blocklayout_register_net(struct net *net, > > > > pipefs_sb = rpc_get_sb_net(net); > > if (!pipefs_sb) > > - return ERR_PTR(-ENOENT); > > + return 0; > > This looks like a typo of some sort. The caller in > nfs4blocklayout_net_init() checks for IS_ERR(), not NULL. I'll just > remove this hunk...
Never mind. I see what's going on now... It should be NULL, and not 0 for coding style reasons, though... -- Trond Myklebust Linux NFS client maintainer NetApp trond.mykleb...@netapp.com www.netapp.com _______________________________________________ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel
