On Fri, 26 Feb 2010 23:52:30 +0100, Andrea Righi <[email protected]> wrote: > Infrastructure to account dirty pages per cgroup and add dirty limit > interfaces in the cgroupfs: > > - Active write-out: memory.dirty_ratio, memory.dirty_bytes > - Background write-out: memory.dirty_background_ratio, > memory.dirty_background_bytes > It looks good for me in general.
> Signed-off-by: Andrea Righi <[email protected]> > --- > include/linux/memcontrol.h | 74 +++++++++- > mm/memcontrol.c | 354 > ++++++++++++++++++++++++++++++++++++++++---- > 2 files changed, 399 insertions(+), 29 deletions(-) > (snip) > +s64 mem_cgroup_page_stat(enum mem_cgroup_page_stat_item item) > +{ > + struct mem_cgroup_page_stat stat = {}; > + struct mem_cgroup *memcg; > + I think it would be better to add "if (mem_cgroup_disabled())". > + rcu_read_lock(); > + memcg = mem_cgroup_from_task(current); > + if (memcg) { > + /* > + * Recursively evaulate page statistics against all cgroup > + * under hierarchy tree > + */ > + stat.item = item; > + mem_cgroup_walk_tree(memcg, &stat, mem_cgroup_page_stat_cb); > + } else > + stat.value = -ENOMEM; > + rcu_read_unlock(); > + > + return stat.value; > +} > + > static int mem_cgroup_count_children_cb(struct mem_cgroup *mem, void *data) > { > int *val = data; > @@ -1263,10 +1419,10 @@ static void record_last_oom(struct mem_cgroup *mem) > } > > /* > - * Currently used to update mapped file statistics, but the routine can be > - * generalized to update other statistics as well. > + * Generalized routine to update memory cgroup statistics. > */ > -void mem_cgroup_update_file_mapped(struct page *page, int val) > +void mem_cgroup_update_stat(struct page *page, > + enum mem_cgroup_stat_index idx, int val) > { > struct mem_cgroup *mem; > struct page_cgroup *pc; ditto. > @@ -1286,7 +1442,8 @@ void mem_cgroup_update_file_mapped(struct page *page, > int val) > /* > * Preemption is already disabled. We can use __this_cpu_xxx > */ > - __this_cpu_add(mem->stat->count[MEM_CGROUP_STAT_FILE_MAPPED], val); > + VM_BUG_ON(idx >= MEM_CGROUP_STAT_NSTATS); > + __this_cpu_add(mem->stat->count[idx], val); > > done: > unlock_page_cgroup(pc); Thanks, Daisuke Nishimura. _______________________________________________ Containers mailing list [email protected] https://lists.linux-foundation.org/mailman/listinfo/containers _______________________________________________ Devel mailing list [email protected] https://openvz.org/mailman/listinfo/devel
