Looks sensible - maybe we should ban all characters not in [a-zA-Z0-9._-] ?
Paul On Jan 23, 2008 9:20 PM, YAMAMOTO Takashi <[EMAIL PROTECTED]> wrote: > hi, > > the following patch rejects '\n' in a cgroup name. > otherwise /proc/$$/cgroup is not parsable. > > example: > imawoto% cat /proc/$$/cgroup > memory:/ > imawoto% mkdir -p " > memory:/foo" > imawoto% echo $$ >| " > memory:/foo/tasks" > imawoto% cat /proc/$$/cgroup > memory:/ > memory:/foo > imawoto% > > YAMAMOTO Takashi > > > Signed-off-by: YAMAMOTO Takashi <[EMAIL PROTECTED]> > --- > > --- linux-2.6.24-rc8-mm1/kernel/cgroup.c.BACKUP 2008-01-23 14:43:29.000000000 > +0900 > +++ linux-2.6.24-rc8-mm1/kernel/cgroup.c 2008-01-24 13:56:28.000000000 > +0900 > @@ -2216,6 +2216,10 @@ static long cgroup_create(struct cgroup > struct cgroup_subsys *ss; > struct super_block *sb = root->sb; > > + /* reject a newline. otherwise /proc/$$/cgroup is not parsable. */ > + if (strchr(dentry->d_name.name, '\n')) > + return -EINVAL; > + > cgrp = kzalloc(sizeof(*cgrp), GFP_KERNEL); > if (!cgrp) > return -ENOMEM; > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to [EMAIL PROTECTED] For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: <a href=mailto:"[EMAIL PROTECTED]"> [EMAIL PROTECTED] </a> > _______________________________________________ Containers mailing list [EMAIL PROTECTED] https://lists.linux-foundation.org/mailman/listinfo/containers _______________________________________________ Devel mailing list [email protected] https://openvz.org/mailman/listinfo/devel
