Hi Kester, Some comments on the code, below.
Em 28/07/2011 10:55, <khaberm...@users.sourceforge.net> escreveu: > > Revision: 15227 > http://gar.svn.sourceforge.net/gar/?rev=15227&view=rev > Author: khabermann > Date: 2011-07-28 09:55:15 +0000 (Thu, 28 Jul 2011) > > Log Message: > ----------- > dsh: created package. libdshconfig: created package It's better for reviews and change tracking if you keep one commit per package. > > Added Paths: > ----------- > csw/mgar/pkg/dsh/ > csw/mgar/pkg/dsh/Makefile > csw/mgar/pkg/dsh/branches/ > csw/mgar/pkg/dsh/tags/ > csw/mgar/pkg/dsh/trunk/ > csw/mgar/pkg/dsh/trunk/Makefile > csw/mgar/pkg/dsh/trunk/checksums > csw/mgar/pkg/dsh/trunk/files/ > csw/mgar/pkg/libdshconfig/ > csw/mgar/pkg/libdshconfig/Makefile > csw/mgar/pkg/libdshconfig/branches/ > csw/mgar/pkg/libdshconfig/tags/ > csw/mgar/pkg/libdshconfig/trunk/ > csw/mgar/pkg/libdshconfig/trunk/Makefile > csw/mgar/pkg/libdshconfig/trunk/checksums > csw/mgar/pkg/libdshconfig/trunk/files/ > > Copied: csw/mgar/pkg/dsh/Makefile (from rev 15060, csw/mgar/pkg/template/Makefile) > =================================================================== > --- csw/mgar/pkg/dsh/Makefile (rev 0) > +++ csw/mgar/pkg/dsh/Makefile 2011-07-28 09:55:15 UTC (rev 15227) > @@ -0,0 +1,15 @@ > +# vim: ft=make ts=4 sw=4 noet > + > +default: > + @echo "You are in the pkg/ directory." > + > +%: > + $(MAKE) -C trunk $* > + > +paranoid-%: > + $(MAKE) -C trunk $* || exit 2 > + > +export BUILDLOG ?= $(shell pwd)/buildlog.txt > + > +report-%: > + $(MAKE) -C trunk $* || echo " *** make $* in $$i failed ***" >> $(BUILDLOG) > > > Property changes on: csw/mgar/pkg/dsh/trunk > ___________________________________________________________________ > Added: svn:ignore > + cookies > download > work > > > Added: svn:externals > + gar https://gar.svn.sourceforge.net/svnroot/gar/csw/mgar/gar/v2 > > > Added: csw/mgar/pkg/dsh/trunk/Makefile > =================================================================== > --- csw/mgar/pkg/dsh/trunk/Makefile (rev 0) > +++ csw/mgar/pkg/dsh/trunk/Makefile 2011-07-28 09:55:15 UTC (rev 15227) > @@ -0,0 +1,36 @@ > +# $Id$ > +# TODO (release-critical prefixed with !, non release-critical with *) > +# > +NAME = dsh > +VERSION = 0.25.9 > +GARTYPE = v2 > +CATEGORIES = devel > +RUNTIME_DEP_PKGS_CSWdsh = CSWlibdshconfig > +BUILD_DEP_PKGS = CSWlibdshconfig > + > +DESCRIPTION = Distributed shell. Runs command through rsh or ssh on a cluster of machines. > + > +MASTER_SITES = http://www.netfort.gr.jp/~dancer/software/downloads/dsh-0.25.9.tar.gz > +DISTFILES = $(DISTNAME).tar.gz > + > +# File name regex to get notifications about upstream software releases > +# NOTE: Use this only if the automatic regex creation > +# does not work for your package > +# UFILES_REGEX = $(NAME)-(\d+(?:\.\d+)*).tar.gz You can remove the unused lines. > +# If the url used to check for software update is different of MASTER_SITES, then > +# uncomment the next line. Otherwise it is set by default to the value of MASTER_SITES > +# UPSTREAM_MASTER_SITES = > + > +# for libintl_gettext, libintl_textdomain, libintl_bindtextdomain > +LIBS += -lintl > +export LIBS It's better to let gar handle this by setting EXTRA_LIBS (iirc). Ignition doesn't work in this case, you can make a note why the LIBS variable is exported directly. > +CONFIGURE_ARGS = $(DIRPATHS) > + > +TEST_SCRIPTS = > + > +TEST_TARGET = > + > +include gar/category.mk > + > > > Property changes on: csw/mgar/pkg/dsh/trunk/Makefile > ___________________________________________________________________ > Added: svn:keywords > + Id > > Added: csw/mgar/pkg/dsh/trunk/checksums > =================================================================== > --- csw/mgar/pkg/dsh/trunk/checksums (rev 0) > +++ csw/mgar/pkg/dsh/trunk/checksums 2011-07-28 09:55:15 UTC (rev 15227) > @@ -0,0 +1 @@ > +60734780242172fca9e68d223654292d dsh-0.25.9.tar.gz > > Copied: csw/mgar/pkg/libdshconfig/Makefile (from rev 15060, csw/mgar/pkg/template/Makefile) > =================================================================== > --- csw/mgar/pkg/libdshconfig/Makefile (rev 0) > +++ csw/mgar/pkg/libdshconfig/Makefile 2011-07-28 09:55:15 UTC (rev 15227) > @@ -0,0 +1,15 @@ > +# vim: ft=make ts=4 sw=4 noet > + > +default: > + @echo "You are in the pkg/ directory." > + > +%: > + $(MAKE) -C trunk $* > + > +paranoid-%: > + $(MAKE) -C trunk $* || exit 2 > + > +export BUILDLOG ?= $(shell pwd)/buildlog.txt > + > +report-%: > + $(MAKE) -C trunk $* || echo " *** make $* in $$i failed ***" >> $(BUILDLOG) > > > Property changes on: csw/mgar/pkg/libdshconfig/trunk > ___________________________________________________________________ > Added: svn:ignore > + cookies > download > work > > > Added: svn:externals > + gar https://gar.svn.sourceforge.net/svnroot/gar/csw/mgar/gar/v2 > > > Added: csw/mgar/pkg/libdshconfig/trunk/Makefile > =================================================================== > --- csw/mgar/pkg/libdshconfig/trunk/Makefile (rev 0) > +++ csw/mgar/pkg/libdshconfig/trunk/Makefile 2011-07-28 09:55:15 UTC (rev 15227) > @@ -0,0 +1,27 @@ > +# $Id$ > +# TODO (release-critical prefixed with !, non release-critical with *) > +# > +NAME = libdshconfig > +VERSION = 0.20.9 > +GARTYPE = v2 > +CATEGORIES = devel > + > +DESCRIPTION = Library for parsing dsh-style configuration files. > + > +MASTER_SITES = http://www.netfort.gr.jp/~dancer/software/downloads/libdshconfig-0.20.9.tar.gz > + > +DISTFILES = $(DISTNAME).tar.gz > + > +# File name regex to get notifications about upstream software releases > +# NOTE: Use this only if the automatic regex creation > +# does not work for your package > +# UFILES_REGEX = $(NAME)-(\d+(?:\.\d+)*).tar.gz > + > +# If the url used to check for software update is different of MASTER_SITES, then > +# uncomment the next line. Otherwise it is set by default to the value of MASTER_SITES > +# UPSTREAM_MASTER_SITES = Same comment about unused lines. > +CONFIGURE_ARGS = $(DIRPATHS) > + > +include gar/category.mk > + > > > Property changes on: csw/mgar/pkg/libdshconfig/trunk/Makefile > ___________________________________________________________________ > Added: svn:keywords > + Id > > Added: csw/mgar/pkg/libdshconfig/trunk/checksums > =================================================================== > --- csw/mgar/pkg/libdshconfig/trunk/checksums (rev 0) > +++ csw/mgar/pkg/libdshconfig/trunk/checksums 2011-07-28 09:55:15 UTC (rev 15227) > @@ -0,0 +1 @@ > +c3fabfae1782c17ee989373c2f6a73c1 libdshconfig-0.20.9.tar.gz > > > This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. > _______________________________________________ > devel mailing list > devel@lists.opencsw.org > https://lists.opencsw.org/mailman/listinfo/devel
_______________________________________________ devel mailing list devel@lists.opencsw.org https://lists.opencsw.org/mailman/listinfo/devel
