On Mon, Jun 16, 2025 at 01:46:59 +0200, Hector Cao wrote:
> Hello,
>
> A friendly ping,
>
> To fix this issue, I would like to propose this solution.
> Here is the draft patch, I can submit a proper one in a separate mail if we
> can reach an agreement
> on this solution.
>
> Thanks !
>
> diff --git a/src/cpu/cpu_x86.c b/src/cpu/cpu_x86.c
> index 0f7eb8f48b..570160c18f 100644
> --- a/src/cpu/cpu_x86.c
> +++ b/src/cpu/cpu_x86.c
> @@ -2922,6 +2922,16 @@ virCPUx86GetHost(virCPUDef *cpu,
> },
> };
>
> + if ((item.data.msr.index == 0x48B)
> + || (item.data.msr.index == 0x48D)
> + || (item.data.msr.index == 0x48E)
> + || (item.data.msr.index == 0x48F)
> + || (item.data.msr.index == 0x490)
> + ) {
> + item.data.msr.eax = item.data.msr.edx & ~item.data.msr.eax;
> + item.data.msr.edx = 0;
> + }
> +
> virCPUx86DataAdd(cpuData, &item);
> }
> }
I think the change does not belong here. The logic should be implemented
in sync_qemu_features_i386.py script to make sure our feature
definitions are correct.
Jirka
