Hi Michal, On Mon, Jun 23, 2025 at 10:05:20AM +0200, Michal Prívozník wrote: ... > > Code-wise this is okay. I've merged some patches together and made small > changes. You can find them here: > > https://gitlab.com/MichalPrivoznik/libvirt/-/compare/master...review_acpi_initiator?from_project_id=192693 > > (I'll be squashing those 'fixup' commits, naturally) > > What I am more worried about is the XML representation. But I'm failing > to come up with a better one. Dan, what do you think?
Thanks for reviewing this! All your fixup commits look good to me. I'm also unsure how to improve the XML representation, but I'm open to suggestions, if anyone has ideas, we can certainly update the schema. Do you want me to send a new patch set with your changes applied? Thanks, -Andrea
