On 20/07/15 23:49 +0200, Michael Schwendt wrote:
and xcf-pixbuf-loader is in a poor state
at Fedora and upstream, too:
https://lists.fedoraproject.org/pipermail/devel/2014-November/204608.html
http://pkgs.fedoraproject.org/cgit/xcf-pixbuf-loader.git/log/
That is also lost in the gitorious.org vortex, and the code looks very
smelly in places.
For example this can't be right:
if (rgb1[0] == rgb1[1] == rgb1[2]) {
Presumably that's meant to be:
if (rgb1[0] == rgb1[1] && rgb1[0] == rgb1[2]) {
Elsewhere it should be checking the return value of fread() and
fseek() for errors, instead of assuming the input file is always
valid.
There also seem to be memory leaks and temporary files not removed on
error.
Yuck.
--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
