On 11/19/2013 10:55 AM, Mathieu Bridon wrote: > On Tue, 2013-11-19 at 10:32 +0000, Richard W.M. Jones wrote: >> On Tue, Nov 19, 2013 at 06:28:47PM +0800, Mathieu Bridon wrote: >>> Or maybe we could start using %autosetup ? >>> >>> http://www.rpm.org/wiki/PackagerDocs/Autosetup >> >> '%autosetup -S git' for sure, not plain %autosetup. >> >> Git correctly handles file modes and binary patches (not that binary >> patches should be much of a concern here, but file modes definitely >> are).
BTW patch 2.7 does support file mode changes: http://savannah.gnu.org/forum/forum.php?forum_id=7361 Binary patches are not yet supported but they are quite useful and I've hit that with patches adding new png files for example. On the topic of new files, `%autosetup -S git` currently doesn't handle those: https://bugzilla.redhat.com/1059285 cheers, Pádraig. -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct
