On 09/25/2013 10:48 AM, Chris Murphy wrote:
On Sep 25, 2013, at 6:12 AM, Ric Wheeler <rwhee...@redhat.com> wrote:
We should not confuse TRIM that gets handled at the device layer (and is a 
slow, non-queued S-ATA command for example) and a dm-thin parsing of that same 
command in software which just updates the metadata that dm-thin maintains.
Yes, fair point. I should have qualified the assertion better to indicate 
default discard to the physical device is probably not a good idea. Or maybe it 
needs to get smarter, and initiated when the fs isn't particularly busy. A kind 
of delayed discard.


Chris Murphy

We do have fstrim - you run it periodically on an online file system and it sends down larger discard requests. That is actually pretty much always the best way to go.

That said, we definitely could use lots of work on looking at performance on top of dm-thin (with/without the discard mount options)....

Ric

--
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel
Fedora Code of Conduct: http://fedoraproject.org/code-of-conduct

Reply via email to