On Tue, 2012-06-26 at 21:51 -0500, Michael Cronenworth wrote:
> On 06/26/2012 06:54 PM, Tom Lane wrote:
> > I beg to differ.  If Bill doesn't get his wrist slapped by FPC, I'll
> > be implementing this for postgresql tomorrow, because I'm tired of
> > hearing complaints about it.
> 
> I must be the only one that prefers your separate postgresql-setup 
> script over the call to service.

You're not.

Especially since it handles multiple postgresql instances with an
optional parameter.

Tom, can you try to make sure the script
in /usr/libexec/initscripts/legacy-actions allows the same?

Ideally, it would be possible for the admin to do something minimal like
the following:
# ln -s /usr/libexec/initscripts/legacy-actions/myinstance \
        /usr/libexec/initscripts/legacy-actions/postgresql

And the script would automatically know (based on the path) what service
it's supposed to handle (i.e get the right PGPORT and PGDATA)

Looking at postgresql-setup this shouldn't be too hard, instead of
getting:
    SERVICE_NAME=$2
it could be something like:
    SERVICE_NAME=$(basename $(dirname $0))

> IMHO "service" is dead.

Well, I guess we'll still be able to run
the /usr/libexec/initscripts/legacy-actions/foo/bar scripts manually? :)


-- 
Mathieu


-- 
devel mailing list
devel@lists.fedoraproject.org
https://admin.fedoraproject.org/mailman/listinfo/devel

Reply via email to