On 07/11/2011 05:40 PM, Michał Piotrowski wrote: > Hi, > > W dniu 11 lipca 2011 17:09 użytkownik Michal Hlavinka > <mhlav...@redhat.com> napisał: >> ok, complain about memcpy in ecryptfs-utils is gone. I've checked all of >> them and I think I've fixed those which needed it. I was not able to >> reproduce original problem nor valgrind complaint, so please test if >> following package produces memcpy complain in valgrind output or not: >> >> http://kojipkgs.fedoraproject.org/scratch/mhlavink/task_3190860/ > > Your mtab handling patch fixed both issues - mount warning and data > corruption :) Huge thanks!
I can't imagine *how* it could affect this, so I'd advice to monitor it carefully if it is fixed for real. Btw, there is not only mtab patch, but 2x memcpy -> memmove too, just not all of them as in previous test package (which did not help). >> Could you describe your environment in more details so we can try to >> reproduce it? For example what ecryptfs options you use (including fstab >> line if you have any), samba configuration etc... > > I do not think that it had any significance - it seems to me that > these options are pretty standard > mount -t ecryptfs /home/$SHARE/ /home/$SHARE/ -o > key=passphrase,ecryptfs_cipher=aes,ecryptfs_key_bytes=16,ecryptfs_passthrough=n,ecryptfs_fnek_sig=some_value > > It's a little strange that you could not reproduce that mount warning. AFAIK that memcpy warning from valgrind gets triggered only if you use "correct" -o ... option -- devel mailing list devel@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/devel
