On Tue, 2025-12-16 at 10:21 +0700, Cristian Le via devel wrote: > Hi Petr, > > On 2025/12/15 21:32, Petr Menšík wrote: > > I have another question. Is it possible to have rpminspect tests run > > on PR? > Yes, please enroll your packages in packit Fedora CI [1] for those. > Technically Zuul does it too, but enrollment there is being closed to > prepare for the migration (announcement coming soon). > > If yes, is it possible to add abidiff check into gating.yaml and block > > certain ABI changes, unless waiver is given? > This is tricky. You can add rpminspect test in general to the > `gating.yaml`, but not individual checks. We could do some > post-processing of the testing-farm tests, but it is unclear what the > syntax in the `gating.yaml` should be to specify what tests/checks you > want to gate against (only plan separation is defined). Please open a > ticket for Fedora CI [2] and give us any idea on the syntax. Maybe AdamW > could also help nail down the details there? > > [1]: https://packit.dev/fedora-ci/configuration > [2]: https://pagure.io/fedora-ci/general
This is actually something I've wondered about before, too. rpminspect is really more a compendium of tests than a single test. I've always kinda thought people might want to gate on subsets of them, so I'm not surprised it's come up. I've filed a ticket with my thoughts on this - my idea is that, as well as the overall synthesized result, we should submit individual reports for each rpminspect subtest (they're called 'inspections' upstream): https://github.com/fedora-ci/rpminspect-pipeline/issues/103 another potential approach would be to make it possible, in rpminspect local configuration, to configure inspections as: run (voting) run (non-voting) not run rather than just: run (voting) not run which are your current choices. A "non-voting" inspection would run and its result would be shown, but it would always be considered a 'pass' for the purpose of calculating the *overall* rpminspect result (i.e. whether it exits 0 or 1). It's possible (though this is not perhaps widely known) to include an rpminspect local configuration in your package's dist-git repo, to customize the behavior of rpminspect when CI tasks run it on that repo. See https://github.com/rpminspect/rpminspect/blob/main/doc/configuration.rst#rpminspectyaml -- Adam Williamson (he/him/his) Fedora QA Fedora Chat: @adamwill:fedora.im | Mastodon: @[email protected] https://www.happyassassin.net -- _______________________________________________ devel mailing list -- [email protected] To unsubscribe send an email to [email protected] Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/[email protected] Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
