Hi,

I'm currently trying to work on fixing a bug which arises when attempting to 
layer the `systemtap-runtime` package on a Fedora Atomic distro. I think this 
is fairly high priority since this package is pulled in as a dependency of 
`qemu`, which is probably fairly commonly used.

Fedora Atomic bug documented here: 
https://bugzilla.redhat.com/show_bug.cgi?id=2359764

I think this bug comes from the systemtap .spec's use of traditional (non 
sysusers.d) methods to handle user creation. I tried to author a PR to solve 
this issue in the Fedora package repo: 
https://src.fedoraproject.org/rpms/systemtap/pull-request/32

After submitting the PR, I was informed that a prior PR had already solved this 
issue: https://src.fedoraproject.org/rpms/systemtap/pull-request/31

That prior PR made it into this recent release, which is now available in F42 
as of a few days ago: 
https://bodhi.fedoraproject.org/updates/FEDORA-2025-fb27254eca

Unfortunately, this hasn't fixed the issue for me. So I'm looking again at the 
spec (maintained upstream) to try and work out what might still be the problem 
and possibly re-factor my PR to properly solve the issue.

I might be completely missing something, but the conditional branching logic 
introduced by the PR above (f892ad26592f97d32984ae088634e82c3c973138) seems to 
be backwards. From what I can tell, the branching conditional logic is actually 
checking for any version of Fedora *below* 42 and runs the updated sysusers.d 
logic if that check matches. This seems to be the opposite of the intended 
logic, as newer Fedora versions should use the newer sysusers.d logic.

I could fix this with a PR but wanted to get some second opinions as I must be 
missing something. A second committer came along afterwards and added 
(fc1a9c24f7167b6c11fed67597141730ee478114) which adds similar logic to check 
for RHEL versions *below* 11.

Any thoughts? If I'm right in thinking this is an error in the logic, I'll try 
and rework my PR.
-- 
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to