On Tue, Apr 29, 2025 at 9:00 PM Adam Williamson <adamw...@fedoraproject.org> wrote: > > So today I came to update a package I created a couple of years back > using rpmautospec - python-pyasyncore . When I created the package, I > had it use %autochangelog : > > https://src.fedoraproject.org/rpms/python-pyasyncore/c/4536a3345e95d1c13b0ad8d6b2ccb347fa8fb436?branch=rawhide > > I note in https://fedoraproject.org/wiki/Changes/rpmautospec that the > scope says "Adjust the mass-rebuild script so it only adds a suitable > git commit log message for spec files using %autorelease/%autochangelog > (NB: uses rpmdev-bumpspec, so no change necessary here)". However, now > I come back to the package, it's got a bunch of changelog entries from > mass rebuilds: > > https://src.fedoraproject.org/rpms/python-pyasyncore/blob/0af868549cc7f6932a871c987226f7f4f3f6b4a2/f/python-pyasyncore.spec#_57 > > why? Is it because I didn't also use %autorelease ? If so, this seems > like a bug somewhere - changelog entries shouldn't be added if the > package uses %autochangelog , even if it doesn't use %autorelease . > > I guess I'll have to fix this up manually by creating a changelog file > that includes the previously autogenerated first entry...
So I think you are hitting the conflagration of two separate issues here: 1. rpmautospec detection in rpmdev-bumpspec was a bit broken (both should have been fixed as of [1] and [2] though, not sure why it kept happening to this particular package). IIRC it used to only consider presence of %autorelease and if that wasn't present, it bumped Release and added a %changelog entry. 2. Using %autorelease without %autochangelog (or vice versa) was always a bit ill-advised, exactly because of tooling corner cases and bugs like 1. Was there a reason why you only applied rpmautospec partially to the package on import? Fabio [1]: https://pagure.io/rpmdevtools/c/5ea187c7f60f77b01ec8cee676c1a49fac68fcb5?branch=main [2]: https://pagure.io/rpmdevtools/c/30eca1b7a06a2df5bbfa3bfd6a4c89c19c6ebd60?branch=main -- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
