On 2025/03/18 11:35, Zbigniew Jędrzejewski-Szmek wrote:
At the technical level, you may be completely right. But at the level of the organization of the work in the distro, this change is very disruptive.
Yes, I am not arguing that the pushing of my PR without a change proposal was a bad idea.
The original reasoning was that at that point various packages were failing due to CMake 4.0 policy drop, and given that the affected packages had minimum CMake version set to <3.5, it coincided with the period before `GNUInstallDirs`. When reviewing the packages for the minimum CMake version 3.5, it is also a good time to check other outdated standards. Since then the `CMAKE_POLICY_VERSION_MINIMUM` was introduced, which hides the fact that those packages still need to be reviewed since the -devel packages are still likely to be broken.
Yes, there are other packages post 3.5 that I did not account for and I am doing the overdue impact check right now. My commit should be reverted as soon as possible to unblock the build failures, but we still have unchecked fallought to go through due to `CMAKE_POLICY_VERSION_MINIMUM`.
When we write the change proposal, I will communicate better the suggested changes and have snippets of how upstream can migrate.
-- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
