On Fri, 2025-02-07 at 18:13 +0000, Zbigniew Jędrzejewski-Szmek wrote: > On Fri, Feb 07, 2025 at 04:54:36PM +0100, Florian Weimer wrote: > > * Zbigniew Jędrzejewski-Szmek: > > > > > Indeed. Apparently I was too hasty with the retirement. The package is > > > being unretired, so this be resolved soon. > > > > Do we need to add back the glibc dependency? > > I don't think so. Unless we observe problems without it… > It was added in https://bugzilla.redhat.com/show_bug.cgi?id=1757267, > but that was long time ago. So maybe we'll be fine with the new dnf > and a better resolver?
I would suggest it might be wise to replace it with a dependency on filesystem. It at least clearly needs a Requires(pre) on filesystem, as it has a %pre script which does stuff that assumes the filesystem is in place. Per the discussion on that bug, it seems like there was also an intent to have a run-time dependency on setup via basesystem; removing the basesystem dependency without replacement means glibc no longer has a runtime dependency on setup, which seems like the problem we wanted to fix in that bug. So I'd say instead of just removing these lines: Requires(pre): basesystem Requires: basesystem as the current commit did, we should change them to: Requires(pre): filesystem Requires: filesystem That both seems defensibly "correct", and pragmatically like it should be closest to current behaviour. setup is denoted as a 'protected' package in dnf, which means it's hard to remove it with dnf, but that doesn't ensure it gets installed (or gets installed before glibc during initial deployment), and you could still in theory do `rpm -e setup`. This would ensure that doing so makes *rpm* complain about you doing that (i.e. protection at rpm level as well as dnf level). -- Adam Williamson (he/him/his) Fedora QA Fedora Chat: @adamwill:fedora.im | Mastodon: @ad...@fosstodon.org https://www.happyassassin.net -- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
