On 26-09-2024 01:10, Marcin Dulak wrote:
I noticed some of my builds started to fail due to environment-modules
not being installed anymore in the build root. Only builds from and
including f41 succeed. Builds for f39, f40, epel9, epel10 fail. Is this
expected?
In the case below of 
1.https://koji.fedoraproject.org/koji/taskinfo?taskID=123906939
  f40 where using BuildRequires: environment(modules) (or no br at all)
fails, I see lmod is installed instead of environment-modules.

Maybe your answer is buried somewhere in [1] or [2]. Two bugs related to a BR on `environment(modules)` no longer leading to environment-modules being installed.

I think the main take away is in comment 11 of the first bug:

ultimately it needs to be able to do "module load <module>". And I believe Lmod does provide this functionality

Would one expect the macros %{_openmpi_load} and %{_mpich_load} to work 
independently of lmod or environment-modules?
Those macros expand to `module load mpi/...`. I believe that's provided by the rpm-mpi-hooks package, which both, openmpi-devel and mpich-devel, require. So, yes, the macros should work with either provider of `environment(modules)`

Who should make the choice of buildrequires between lmod and 
environment-modules? The spec file that specifies buildrequires openmpi-devel, 
or openmpi-devel itself?

It's actually further down the rabbit hole in rpm-mpi-hooks, which until [1] happened, had a BR on `environment(modules)`, but has since switched to `environment-modules` [3].

Anyway, long story short, using BRs for the MPI devel packages should be all you need, unless you want to explicitly overwrite it. Since it doesn't, I suppose the quote above is incorrect and the fix implemented back then needs to propagate to the other branches.


[1] https://bugzilla.redhat.com/show_bug.cgi?id=2302033
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2302036
[3] https://src.fedoraproject.org/rpms/rpm-mpi-hooks/c/90f8dfbf925a815820cd1bcdd469c8827a757b19?branch=rawhide

-- Sandro

--
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to