Hi all, I like using `fedpkg local` builds to speed up testing of packaging, but now encountered a problem trying to package a rust program for the first time. It turns out a local build fails in the install step for all rust packages (that I tried out) with an error like
error: 152 files in the working directory contain changes that were not yet committed into git: [ ... file list ... ] to proceed despite this and include the uncommitted changes, pass the `--allow-dirty` flag The problem is the line /usr/bin/env CARGO_HOME=.cargo RUSTC_BOOTSTRAP=1 RUSTFLAGS='-Copt-level=3 -Cdebuginfo=2 -Ccodegen-units=1 -Cstrip=none -Cforce-frame-pointers=yes -Clink-arg=-specs=/usr/lib/rpm/redhat/redhat-package-notes --cap-lints=warn' /usr/bin/cargo package -l | grep -w -E -v 'Cargo.(lock|toml.orig)' | xargs -d '\n' /usr/bin/cp --parents -a -t $REG_DIR coming from the `%cargo_install` macro, where `cargo package -l` is used to generate the file list. Now, since `fedpkg local` builds inside a subdirectory of the package repo, `cargo package` sees that it's operating inside a git repo and issues the above warning, exiting non-zero. I know to work around this by using rpmbuild manually or testing with mock builds all the time, but I think it would be great if local builds would work, too. Maybe we could add the `--allow-dirty` to the `%cargo_install` macro - from the top of my head this should not break anything, but I'm not sure. There does not seem to be a general "ignore-git" option for cargo. Or are there other ways to get this to work? Greetings, Philip Matura -- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
