Hello,

I wanted to ask about the right tactic to make a change in Fedora 40. Libcap-
ng is ready for a new release. I want to remove a Fedora only patch that 
allows an errant call to capng_apply to succeed.

Back in Oct 2020, a bug was reported upstream where the user needed to know 
that a call to capng_apply failed because its bounding set did not have the 
right permission but success was being accidentally returned. This bug was 
fixed and libcap-ng-0.8.1 was released with the issue fixed.

Soon after, people started noticing other applications failing because it was 
now passing the error back to the caller. A few examples:

https://bugzilla.redhat.com/show_bug.cgi?id=1899540
https://bugzilla.redhat.com/show_bug.cgi?id=1899840
https://bugzilla.redhat.com/show_bug.cgi?id=1924218
https://bugzilla.redhat.com/show_bug.cgi?id=1952715
etc

This really was a problem in all these applications. But we couldn't allow 
them to just fail, so a patch was created that reverted the behavior but 
syslogged that it would have failed. Then a new wave of bug reports came for 
applications that didn't check the return code that now had warnings in 
syslog.

That was 3 years ago. I think it's been long enough that any applications 
that had problematic behaviour should have had the syslog message reported 
upstream and fixed. In September of this year, I pushed out an updated version 
of libcap-ng that had warn about unused results annotations added to the 
canng_apply function declaration. This was to increase visibility to anyone 
doing builds.

So, what should I do to remove the patch? Do I push the new release into 
rawhide without the patch or does this need to go through the Fedora Change 
Process? And if so, self-contained or system wide?

Thanks,
-Steve

--
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to