> Except that it's not 100% compatible, since all those packages aren't > building/working with zlib-ng-compat. At a minimum, you should be able > to show that everything zlib-dependent successfully rebuilds with this, > and since you've already identified some that don't, IMO they should be > fixed *first*.
He didn't say the packages weren't working, he said the tests failed, typically because they hardcoded assumptions about the exact behavior of the compression library. That's a different issue. As a concrete example, a while back I wanted to add zlib-ng as a build time option to the createrepo_c package, and one such test failed because the zlib-ng gzip output was not identical to zlib gzip output, despite the fact that it *was* correct and decompresses correctly: https://github.com/rpm-software-management/createrepo_c/pull/339/commits/1f3549bfe6ea45e6fd099c0582893766061198c8 It so happened that within days there was another reporter who needed the same fix but for different reasons - because that test was broken on z390 where gzip compression is hardware-accelerated: https://github.com/rpm-software-management/createrepo_c/pull/336 So any tests that are breaking because they expected some exact gzipped output as opposed, were likely fragile anyway, and worked only because zlib has changed very little for a very long time - no new compression strategies, no adjustment of which strategies are used by which levels, etc. -- _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
