On 9/27/23 04:43, Peter Robinson wrote: > On Wed, Sep 27, 2023 at 6:24 AM Remi Collet <fed...@famillecollet.com> wrote: >> >> Le 26/09/2023 à 19:32, Carlos O'Donell a écrit : >> >>>> In version 8.3 (F40) we'll includes the UTC definition >>>> in our patch to use system tzdata, UTC being use >>>> as the fallback value. >>> >>> I'm curious; what does this patch look like? >> >> (trivial) patch to our system tzdata patch attached >> >> In short, if file is missing use bundled content >> >> Full patch for PHP 8.3: >> https://git.remirepo.net/cgit/rpms/scl-php83/php.git/plain/php-8.3.0-systzdata-v24.patch >> >> Remi >> >> >> P.S. IMHO, allowing removal of tzdata for PHP doesn't make any sense >> as most app will fail badly (runtime exception) because of missing >> TZ when upstream use a bundle copy of the full database, so this can >> never happen, so this will create another RPM specific problem > > Can't you just explicitly require tzdata?
I agree, if PHP requires tzdata then please add "Requires: tzdata" With any kind of minimization work where we split up the packages we are going to find implicit dependencies that should be made explicit. It is perfectly OK to require tzdata from PHP if that's what is needed for your users, and you know your users best. -- Cheers, Carlos. _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam, report it: https://pagure.io/fedora-infrastructure/new_issue
