On Thu, Jan 19, 2023 at 10:52 AM Michal Schorm <msch...@redhat.com> wrote:

> Would you see a value in e.g. some kind of a robot reminding
> maintainers of such obsolete code? (e.g. new RPMinspect or ZUUL CI
> check)

"Reminding" is another term for nagging.  Fedora should
not be a nag when there may be reasons for the choices
(for example, while one can claim that one should not be
running obsolete system versions, sometimes there are
"reasons", and that system may even be being supported
through an extended support contract).  Packager
workflow can be complicated, and we need to respect
that the many volunteers that contribute to Fedora may
have needs outside of the pure Fedora ecosystem.

Adding such a check to rpmlint when a packager does
their update checks, on the other hand, might be a
reasonable approach, as packagers can decide whether
to remove the code fragments, to override that check in
the rpmlint configuration, or just ignore the suggestion,
as they see fit.

As for my personal practice, I tend to remove such old
code when I decide to review the entire spec file (i.e.
review/modernize it for current packaging guidelines
typically with a major new version of the software, or
I have just adopted an orphaned package that I need),
or the spaghetti if/elses become confusing even to myself,
and it needs cleaning, or when I am trying to avoid
doing something else (sometimes it seems like cleanup
should be quick and easy (sometimes it is neither)
which I think I can actually accomplish right now).
I rarely go looking for new things to add to my
infinitely long TODO list just because I could add it.
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam, report it: 
https://pagure.io/fedora-infrastructure/new_issue

Reply via email to