On Mon, Apr 04, 2022 at 01:39:12PM -0400, Kevin P. Fleming wrote:
> (moving thread here from Ask Fedora)
>
> I use `tlp` and `tlp-rdw` on my laptop to manage power/performances modes,
> and enable/disable the WiFi radio. With F35 this was working fine.
>
> On Friday I did an in-place upgrade to F36 Beta, and this morning I
> realized that two default services that I had masked (so that `tlp` could
> do its job) were unmasked during the upgrade.
>
> Specifically, `power-profiles-daemon.service` and `systemd-rfkill.service`
> were unmasked. Since masking creates a symlink (to /dev/null) in
> /etc/systemd/system, which is a user-managed directory, I was quite
> surprised that the upgrade removed the symlinks.
tlp has scriptlets to unmask systemd-rfkill.service and
power-profiles-daemon.service on upgrades, see [1].
Previously, tlp had scriptlets to mask those services. This was causing
problems elsewhere, and was a violation of the general rule that packages
should not interfere with other packages, and in [2]
the removal of that scriptlet was requested, and approved by FESCo in [3]
("tlp must drop its own preset file and the calls to mask/unmask
services in another package").
In the end Jeremy (the maintainer) went even further and added a
scriptlet to unmask those services. This clearly had good intent, but
the scriptlet is iffy: it'll unmask those services on every
upgrade, even if the user masks them again. It'd be better to implement
this as a trigger:
%triggerun -- tlp < 1.4.0-3
# undo masks that were done in older versions
[ -x /usr/bin/systemctl ] && systemctl unmask systemd-rfkill.service
power-profiles-daemon.service || :
(That is assuming that the unmask is wanted at all. I'm not sure,
seems that the situation is messy, with one or the other service suffering.)
Reading the bug, it seams that Bastien was supportive of the unmask.
I'm adding Jeremy and Bastien in CC. I'm not sure how the final
solution should look here.
[1]
https://src.fedoraproject.org/rpms/tlp/c/adc5a616398ddedbcf9c2eda29b5d856837a0f29?branch=rawhide
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2028701
[3] https://pagure.io/fesco/issue/2725
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
