On Do, 24.02.22 10:14, Colin Walters (walt...@verbum.org) wrote: > I think instead you can use e.g. a systemd generator: > https://www.freedesktop.org/software/systemd/man/systemd.generator.html > The generator (which can be the same binary) can then enable iscsi.service > only if the directory is non-empty.
I would agree with this: I think the iscsi packagae should carry small generator that pulls in the iscsi stack into the initial systemd transaction if there's at least one entry in /var/lib/iscsi/nodes that shall be set up at boot. i.e. it should just create one symlink pulling iscsi.service into remote-fs-pre.target if there's an iscsi device to set up. This could be a shell script even, if you must. That way if people configure an iscsi node to be set up at boot via that nodes file, then this is enough to ensure it is really set up, and a secondary, manual enablement of iscsi.service is not necessary. And of course, we wouldn't enable iscsi.service by default anymore. To me this appears to be the perfect behaviour. Lennart -- Lennart Poettering, Berlin _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
