On 1/21/22 13:47, Richard W.M. Jones wrote:
On Fri, Jan 21, 2022 at 01:30:38PM +0100, Paolo Bonzini wrote:
On 1/21/22 10:49, Richard W.M. Jones wrote:
Yes that works!
Are you going to make the change? (For all of the QEMU firmware
packages---edk2, openbios, seabios in addition to SLOF---since you
are at it).
However edk2 has other problems revealed probably by GCC 12, see:
https://kojipkgs.fedoraproject.org//work/tasks/4195/81484195/build.log
A valid warning, perhaps slightly overzealous depending on how Error is defined:
GenSec.c:1065:5: error: pointer used after 'fclose' [-Werror=use-after-free]
1065 | Error(NULL, 0, 4001, "Resource", "memory cannot be allocated of
%s", InFileHandle);
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
GenSec.c:1064:5: note: call to 'fclose' here
1064 | fclose (InFileHandle);
| ^~~~~~~~~~~~~~~~~~~~~
But it seems more likely that the bug is real. Maybe that %s should be %p,
or the function call is bogus in some other way.
openbios has a segfault somewhere during the FORTH bootstrap:
https://kojipkgs.fedoraproject.org//work/tasks/6090/81556090/build.log
I was not able to reproduce this one locally.
I would try reproducing with -O0 first. It might be a dup of the QEMU bug
https://gcc.gnu.org/PR104067, even. It's a problem with loop optimizations,
so it could be the kind of thing that can wreak havoc on a FORTH interpreter!
Once the fix for PR104067 hits Fedora, if it's not fixed I can take a look.
Thanks,
Paolo
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it:
https://pagure.io/fedora-infrastructure
