On Mon, Dec 6, 2021 at 12:49 PM Bernie Innocenti <ber...@codewiz.org> wrote: > > Hello David, > > This spirv-tools-libs build changed the ABI of libSPIRV-Tools.so in > Rawhide on Nov 23: > https://koji.fedoraproject.org/koji/buildinfo?buildID=1858749 > > The shared lib has no soversion, and other libs in Fedora depend on it: > > mpv: symbol lookup error: /lib64/libshaderc_shared.so.1: undefined > symbol: _ZN8spvtools23CreateAggressiveDCEPassEv > > On Dec 2nd, libshaderc was also rebuilt, and now it agrees with the new > ABI of spirv-tools-libs: > https://koji.fedoraproject.org/koji/buildinfo?buildID=1862359 > > However, libplacebo would also need rebuilding: > > undefined symbol: _ZN8spvtools23CreateAggressiveDCEPassEv > (/lib64/libplacebo.so.157) > > I rebuilt it locally, but there are more packages using the old ABI: > > % mpv > mpv: symbol lookup error: /lib64/libavfilter.so.7: undefined symbol: > _ZN8spvtools23CreateAggressiveDCEPassEv > > I would like to request that we revert the ABI of libSPIRV-Tools.so or, > at least bump the soversion to avoid silently breaking all dependencies. > > What are the current Fedora packaging guideline regarding ABI stability > of shared libraries?
This library has no ABI guarantees upstream, which is painful to deal with. I've figured out what they messed up and hopefully put things back like they should be with the correct ABI. Thanks for the headsup, sorry it took a bit longer to get to it, I've filed an upstream MR to restore the ABI there, to avoid it in future. Dave. > > Are there no automated checks to prevent this common accident? This > happens frequently, and discourages Rawhide testing. > > Thanks, > > -- > _ // Bernie Innocenti > \X/ https://codewiz.org/ > _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
