On Wed, Aug 18, 2021 at 11:02 AM Dave Young <dyo...@redhat.com> wrote:

> Add Kazu in cc list
> On Wed, 18 Aug 2021 at 10:45, lijiang <liji...@redhat.com> wrote:
> >
> > Hi,
> >
> > In Fedora crash.spec, currently the LTO is disabled as below:
> >
> > +# This package has an internal copy of GDB which has broken configure
> code for
> > +# INTDIV0_RAISES_SIGFPE and MUST_REINSTALL_SIGHANDLERS
> > +# Updating that code properly seems nontrivial and best left to the
> package
> > +# maintainer.
> > +# Disable LTO
>
> Hi Lianbo,  the above words seem to suggest disable LTO intentionally,
>

Yes. I copied the above words from the Fedora crash.spec.


> I know the upstream crash tool is working on gdb 10.x integration,
> maybe the above is eased already with the latest gdb update?
>
>
It doesn't enable LTO on upstream by default.


>
> > +%define _lto_cflags %{nil}
> >
> > commit: c6fc69dae3a2 ("Disable LTO")
> >
> > I tried to remove the macro "%define _lto_cflags %{nil}" from the
> crash.spec, and then build the rpm packages, But I didn't see the lto flag
> such as "-flto" or "-ffat-lto-objects" during the whole build stage, and
> the build process passed without any error reports.
> >
>

I did the above build test on Fedora rawhide.


> > I'm wondering if it could rely on the redhat-rpm-config macro or it(LTO
> flag) can take effect when the toolchain is clang(not gcc)? Any thoughts?
>
> The question seems about how to enable LTO instead of if it is ok to
> enable LTO. Maybe Jeff and others can provide some inputs
>
>
Thank you for helping to clarify this, Dave.

>
> > Thanks.
> > Lianbo
> >
> >
> >
> > But
>
> Thanks
> Dave
>
>
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
Do not reply to spam on the list, report it: 
https://pagure.io/fedora-infrastructure

Reply via email to