On Tue, Aug 3, 2021 at 11:50 AM Florian Weimer <fwei...@redhat.com> wrote:
> * Kaleb Keithley: > > > in f35 leveldb-1.22's libleveldb.so.1.22 has, among others, the > following: > > > > # nm -D libleveldb.so.1.22 | grep Logger | grep leveldb > > 00000000000367f0 T _ZN7leveldb6LoggerD0Ev > > 0000000000036740 T _ZN7leveldb6LoggerD1Ev > > 0000000000036740 T _ZN7leveldb6LoggerD2Ev > > 00000000000557a0 D _ZTIN7leveldb6LoggerE > > 0000000000046650 R _ZTSN7leveldb6LoggerE > > 0000000000055778 D _ZTVN7leveldb6LoggerE > > > > This was recently updated to leveldb-1.23, and libleveldb.so.1.23 has > > > > # nm -D /usr/lib64/libleveldb.so.1.23.0 | grep Logger | grep leveld > > 0000000000031490 T _ZN7leveldb6LoggerD0Ev > > 00000000000313e0 T _ZN7leveldb6LoggerD1Ev > > 00000000000313e0 T _ZN7leveldb6LoggerD2Ev > > 000000000004c470 D _ZTVN7leveldb6LoggerE > > > > This looks like an ABI change to me. > > > > And it broke the ceph :-(. ( > https://bugzilla.redhat.com/show_bug.cgi?id=1989452) > > -fno-rtti is not an ABI-compatible change, so the soname should have > been updated, yes. I reported it upstream: > ah, I missed that. I looked, but not hard enough apparently, and I presumed it was related to changes in the code. > <https://github.com/google/leveldb/issues/927> > > but I expect upstream does not care about ABI. > Maybe the other way would be to patch that change back out in Fedora. Since f34 has been updated to leveldb-1.23 too (in testing) maybe that's a better solution to preserve the ABI and also not bump the soname? I can send a PR to src.fedoraproject.org/rpms/leveldb/ with a patch for that. Thanks. -- Kaleb
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org Do not reply to spam on the list, report it: https://pagure.io/fedora-infrastructure
