In my spec files, I use %cmake, %cmake_build and %cmake_install. A priori, I now that I must add BuildRequires cmake but I don't now the details of the macro. So, I don't now if the %cmake macro is tuned to build a ninja or a make project. I think the cmake should ship a minima the build tools used by the %cmake macro.
----- Mail original ----- De: "Fabio Valentini" <decatho...@gmail.com> À: "Development discussions related to Fedora" <devel@lists.fedoraproject.org> Envoyé: Jeudi 3 Décembre 2020 17:32:24 Objet: Re: Mass spec file change: Adding BuildRequires: make On Thu, Dec 3, 2020 at 5:17 PM Tom Stellard <tstel...@redhat.com> wrote: > > On 12/3/20 7:39 AM, Fabio Valentini wrote: > > On Thu, Dec 3, 2020 at 4:35 PM Tom Stellard <tstel...@redhat.com> wrote: > >> > >> On 12/2/20 5:45 AM, Artem Tim wrote: > >>> How to quickly retest packages which listed here > >>> https://fedorapeople.org/~tstellar/needs_br_make_packages.txt? I've > >>> tested few locally and in Koji Rawhide scratch, but they are compiled > >>> fine. > >>> ___ > >> > >> If the packages use make and they BuildRequire: make then there is > >> nothing else to do. I will try to re-run the scripts everyday to keep > >> the list updated. > > > > I still think a lot of those are "false positives". > > CMake has a hard Requires on make, so if I BuildRequires cmake, adding > > "BuildRequires: make" is just redundant. > > https://src.fedoraproject.org/rpms/cmake/blob/master/f/cmake.spec#_185 > > > > The only safe way to do this is to add BuildRequires: make to every > package that uses make. We can't depend on these dependency chains to > keep things working, because they may not always be there. That argument doesn't hold much water. CMake always requires a backend, and right now it hard-requires make. Until that's no longer the case, adding BR: make to packages already having BR: cmake is just a waste of time. If I can't be sure of *anything*, then wouldn't I have to add the entire expected dependency tree as BRs?, down to glibc and filesystem? _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
