On Thu, Dec 03, 2020 at 04:39:35PM +0100, Petr Šabata wrote:
> On Thu, Dec 3, 2020 at 4:34 PM Pierre-Yves Chibon <pin...@pingoured.fr> wrote:
> >
> > On Thu, Dec 03, 2020 at 04:16:56PM +0100, Petr Šabata wrote:
> > > Since I don't see those on the list, does this impact
> > >
> > > * rpkg (fedpkg)?
> >
> > Wrapper to git, should not be impacted. The only thing I could think of was:
> > when we fedpkg clone an empty git repo, have fedpkg do the "git branch -M 
> > main"
> > directly. That being said, I'm not 100% sure when we creating a project on
> > dist-git today we create them empty.
> 
> Also fedpkg anything that tries to figure out what the release string
> and build target are based on the branch name. E.g. fedpkg build.

Good point

> > > * koji (if no git commit is provided)?
> >
> > koji builds from a git reference be that a commit, branch name or git tag.
> > There will be no consequences for koji there (instead of building from
> > url#master you'll be build from url#main).
> 
> Yes, but I think, and correct me if I'm wrong, that if the SCMURL is
> simply a repo name, it uses master HEAD. You could say it's an edge
> case but if it does that, is should now attempt to use main, with
> master as a fallback.

It then uses HEAD which would be the same thing as what you get when you git
clone a repo and with this change it'll point to main.

Something to test/confirm, but I'm really pretty sure that it'll be fine.


Pierre
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Reply via email to