On 11/6/20 12:16 AM, Sandro Mani wrote:
Hi

I've put up another bunch of mingw-python-* packages for review which I used to maintain in COPR but I'd like to move into Fedora proper:

mingw-python-pytz - https://bugzilla.redhat.com/show_bug.cgi?id=1895157
mingw-python-chardet - https://bugzilla.redhat.com/show_bug.cgi?id=1895161
mingw-python-idna - https://bugzilla.redhat.com/show_bug.cgi?id=1895162
mingw-python-six - https://bugzilla.redhat.com/show_bug.cgi?id=1895164
mingw-python-pygments - https://bugzilla.redhat.com/show_bug.cgi?id=1895165
mingw-python-urllib3 - https://bugzilla.redhat.com/show_bug.cgi?id=1895167
mingw-python-affine - https://bugzilla.redhat.com/show_bug.cgi?id=1895168
mingw-python-OWSLib - https://bugzilla.redhat.com/show_bug.cgi?id=1895172
mingw-python-markupsafe - https://bugzilla.redhat.com/show_bug.cgi?id=1895175
mingw-python-shapely - https://bugzilla.redhat.com/show_bug.cgi?id=1895181
mingw-python-pyyaml - https://bugzilla.redhat.com/show_bug.cgi?id=1895179
mingw-python-setuptools_scm - 
https://bugzilla.redhat.com/show_bug.cgi?id=1895185
mingw-python-lxml - https://bugzilla.redhat.com/show_bug.cgi?id=1895186

Note: The spec is basically identical between all the packages

Hey Sandro. Before we proceed, would it make sense to introduce some macros for this, similar to %py3_build and %py3_install?

E.g. you should be able to do this currently:

%global __python3 %{mingw64_python3}
...
%py3_build
...
%py3_install
...
%{python3_sitearch}/...


However I realize that might be problematic given the two stacks (32- and 64bit). So what if we have:

%mingw32_py3_build
%mingw64_py3_build

And

%mingw32_py3_install
%mingw64_py3_install

Similarly to %{mingw32/64_python3} and %{mingw32/64_python3_sitearch}?

Sound good?


Side note: I see this:

%{mingw64_python3_sitearch}/*

Please, don't do that, see https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include

Thanks
--
Miro Hrončok
--
Phone: +420777974800
IRC: mhroncok
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Reply via email to