On Sun, 20 Sep 2020 at 03:27, Luya Tshimbalanga <l...@fedoraproject.org> wrote:
> On 2020-09-19 1:32 p.m., Andy Mender wrote: > > On Sat, 19 Sep 2020 at 22:27, Richard Shaw <hobbes1...@gmail.com> wrote: > >> On Sat, Sep 19, 2020 at 3:16 PM Luya Tshimbalanga <l...@fedoraproject.org> >> wrote: >> >>> Hello team, >>> >>> openvdb is updated to 7.1.0 in Rawhide and luxcorerender needs to switch >>> to -std=c++14 similar to that upstream ticket: >>> https://github.com/AcademySoftwareFoundation/openvdb/issues/795. >>> >>> Is there anyone knowing how to do it on the spec file? >>> >>> https://src.fedoraproject.org/rpms/luxcorerender/ >>> >>> It seems "sed -i 's|${CMAKE_CXX_FLAGS} -std=c++11|${CMAKE_CXX_FLAGS} >>> -std=c++14|' CMakeLists.txt" is not enough because "-std=c++11" still >>> comes back. >>> >> >> Looks like it's specified here: >> >> cmake/PlatformSpecific.cmake >> >> I would just patch it instead. >> >> > I would also suggest patching the main CMakeLists file, for instance the > following way: > set(CMAKE_CXX_STANDARD 14) > set(CMAKE_CXX_STANDARD_REQUIRED ON) > > If that's not too invasive, of course. > > Thanks for quick response. The suggestion seems to work. Unfortunately, > the build failed on openvdb (either using the bundled and 7.1.0 version) > while working fine on Fedora 32. > The build.log logfile isn't informative at all :(. I would try checking all of the flags the %cmake macro adds to the regular cmake call and try to build the thing outside of mock, locally. Also, maybe set the compiler to clang to get better output: CXX=clang++ CC=clang Clang, at least in my experience, tends to be a lot more pedantic and verbose. However, it may behave differently and fail the build in other ways.
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
