On Friday, 04 September 2020 at 11:00, Daniel P. Berrangé wrote: > I'm looking at cleaning up some parts of the QEMU spec and we have > conditionals in there testing for s390 arch (aka 32-bit). IIRC it > was previously a secondary arch, at least back in the Fedora 22-ish > timeframe. I'm not seeing it listed in the alternative arch list > currently though: > > https://fedoraproject.org/wiki/Architectures > > Am I right in concluding that 's390' does not need to be considered in > RPM spec files now, and thus we can purge any 's390' arch checks ?
Looking at qemu.spec, are you talking about this one? https://src.fedoraproject.org/rpms/qemu/blob/master/f/qemu.spec#_1005 Does it also happen on armv7hl and i686? I guess not. The rest if %ifarch s390 can be dropped as far as I can tell. You can also drop ppc, ppc64 and mips64, too. For example, here: https://src.fedoraproject.org/rpms/qemu/blob/master/f/qemu.spec#_1201 Regards, Dominik -- Fedora https://getfedora.org | RPM Fusion http://rpmfusion.org There should be a science of discontent. People need hard times and oppression to develop psychic muscles. -- from "Collected Sayings of Muad'Dib" by the Princess Irulan _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
