On Tue, Aug 4, 2020 at 1:40 PM José Abílio Matos <jama...@fc.up.pt> wrote:
>
> On Tuesday, 4 August 2020 12.42.30 WEST Neal Gompa wrote:
> > Then you should do the following:
> >
> > %undefine __cmake_in_source_build
> >
> > %cmake
> > %cmake_build
> > %cmake_install
>
> Would not it be more clean to place the %undefine line inside guards?
>
> %if (0%{?rhel} || (0%{?fedora} && 0%{?fedora} < 33))
> %undefine __cmake_in_source_build
> %endif
>
> I am asking this because I always forgot when was a given functionality
> introduced or it is no more required.
>
> A simple example is "rm -rf $RPM_BUILD_ROOT" that I know that it is not
> necessary in Fedora anymore but it is very easy to know in which epel version
> it is necessary ( <= 6 I think).
>
> Does that solution makes sense or am I over-engineering this?
>You're overthinking this a bit. :) Undefining the variable makes it consistent across the board, and there's no impact caused by undefining a variable that's already not defined. You *can* do that if you want, but it doesn't matter. :) -- 真実はいつも一つ！/ Always, there's only one truth! _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
