As Fabio wrote, just I add that you can opene PR in pagure,
which is good way to show people the changes and get some
feedback (as well, creating copr build should be done too).

On 02. 12. 19 13:08, Tomas Korbar wrote:
Thanks for help Fabio.

On Mon, Dec 2, 2019 at 12:10 PM Fabio Valentini <decatho...@gmail.com 
<mailto:decatho...@gmail.com>> wrote:

    On Mon, Dec 2, 2019, 11:45 Tomas Korbar <tkor...@redhat.com 
<mailto:tkor...@redhat.com>> wrote:

        Hi,
        I would like to ask you a question. If upstream of your package does 
major rewrite of it, then what is the proper process to rebase such package? 
I'm maintainer of cheat [0] which has been rewritten in go. I suppose i need a 
new package review but then if the new spec passes review am i supposed to 
replace the spec of old package entirely or preserve changelog and add new 
entry with description of what happened + link to the review?


    Hi Tomas,

    You don't need to go through package review again, since it's not a new 
package. So just update it to the new version, and keep the old changelog.

    However, if you want feedback on the new packaging before pushing it to 
fedora, you could publish the .spec file and submit the new version to a COPR 
repo first, so users can look at it, test it, and give you comments. I do it 
like this for my packages when they have major changes.

    It would be another matter if the new version is installable alongside the 
old version, then you could package both of them separately, but I guess that's 
not the case here.

    Fabio

        [0] - https://github.com/cheat/cheat
        _______________________________________________
        devel mailing list -- devel@lists.fedoraproject.org 
<mailto:devel@lists.fedoraproject.org>
        To unsubscribe send an email to devel-le...@lists.fedoraproject.org 
<mailto:devel-le...@lists.fedoraproject.org>
        Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
        List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
        List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

    _______________________________________________
    devel mailing list -- devel@lists.fedoraproject.org 
<mailto:devel@lists.fedoraproject.org>
    To unsubscribe send an email to devel-le...@lists.fedoraproject.org 
<mailto:devel-le...@lists.fedoraproject.org>
    Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
    List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
    List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org


--
Petr Stodulka
OS & Application Modernization
IRC nicks: pstodulk, skytak
Senior Software Engineer
Red Hat Czech s.r.o.
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct: 
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: 
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org

Reply via email to