* Panu Matilainen:
> On 6/17/19 4:45 PM, Florian Weimer wrote:
>> * Panu Matilainen:
>>
>>> On 6/13/19 12:54 PM, Miroslav Suchý wrote:
>>>> This is wrong (not sure if the culprit)
>>>>
>>>> %endif %{__with_rebar3}
>>>>
>>>> I would rewrite it to:
>>>>
>>>> %endif # __with_rebar3
>>>
>>> Actually both are wrong, and rpm >= 4.15 will complain (unlike old
>>> versions). Rpm only supports comments at beginning of line, and this
>>> only ever worked by accident.
>>
>> Would it be possible to bring back the ability to comment on %endif
>> lines at least? It's nice to have a comment there if the condition is a
>> screen or two away.
>
> Nothing prevents you from putting the comment on the line above:
>
> # __with_rebar3
> %endif
This doesn't follow the usual convention for such comments.
Are # lines stripped always, even in scriptlets?
Thanks,
Florian
_______________________________________________
devel mailing list -- devel@lists.fedoraproject.org
To unsubscribe send an email to devel-le...@lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
