On Mon, 2019-02-25 at 09:58 -0500, Adam Jackson wrote: > On Fri, 2019-02-22 at 19:59 +0000, Sérgio wrote: > > Add -fsigned-char fix the build thanks, I still not understood, why > > only ppc64le and GCC 9 > > I can't speak to the gcc9 part, but this would probably have failed > on > aarch64 and s390x as well, you just didn't notice because those > aren't > arches in copr.
yes , I could check this on koji , aarch64 and others also failed to build. > C's "char" type is either signed or unsigned by default, it's a > function of the processor-specific ABI. It happens to be signed on > i686 > and x86_64, and unsigned on all the other arches Fedora supports. So: > > > /builddir/build/BUILD/gdcm- > > 2.8.8/Testing/Source/Common/Cxx/TestString2.cxx:29:24: error: > > narrowing conversion of '-1' from 'int' to 'char' [-Wnarrowing] > > This would only trigger on unsigned-char arches, because you can't > represent -1 with an unsigned number. The key was "can't represent -1 with an unsigned number" , I add some sign char to the code [1] and it fix the FTBFS Thanks , [1] https://src.fedoraproject.org/fork/sergiomb/rpms/gdcm/blob/master/f/gdcm-2.8.8-fix-narrow.patch > - ajax > _______________________________________________ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org > Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html > List Guidelines: > https://fedoraproject.org/wiki/Mailing_list_guidelines > List Archives: > https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org -- Sérgio M. B. _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
