Dne 31.8.2018 v 13:41 Miro Hrončok napsal(a): > On 31.8.2018 13:30, Miro Hrončok wrote: >> On 31.8.2018 09:05, Igor Gnatenko wrote: >>> On Wed, Aug 22, 2018 at 10:02 PM Ben Cotton <bcot...@redhat.com >>> <mailto:bcot...@redhat.com>> wrote: >>> >>> >>> https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error >>> >>> >>> == Summary == >>> The <code>/usr/lib/rpm/redhat/brp-mangle-shebangs</code> buildroot >>> policy script will be changed to make the build fail when it >>> sees an >>> ambiguous python shebang, such as <code>#!/usr/bin/python</code> or >>> <code>#!/usr/bin/env python</code>. (The script has been warning in >>> these cases for 2 Fedora releases already, saying ''This will >>> become >>> an ERROR''.) >>> >>> >>> Why can't we add something like >>> `MANGLE_UNVERSIONED_PYTHON_TO=%{__python3}`? >> >> >> What about the following: >> >> If %_mangle_python_shebnags_to is set, the script will mangle to that >> (unless it's unversioned python again or otherwise invalid). >> >> If %_mangle_python_shebnags_to is not set (the default), the script >> will error (as currently proposed). > > Probably %_mangle_unversioned_python_shebnags_to becasue that's the > only thing that would be changed. >
And what about not adding such macros at all? After while, the brp-mangle-shebangs will become unmaintainable full of exceptions and moreover you'll have hard time to get rid of such macros in the future, because of backward compatibility. V. _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org
