Daniel P. Berrangé wrote: > On Tue, Jul 24, 2018 at 01:32:45PM -0400, Todd Zullinger wrote: >> Artur Iwicki wrote: >>> That section of the guide is a bit poorly worded. You should *not* use "git >>> add" on source tarballs. These should be added only via means of "fedpkg >>> new-sources $FILES; git add ./sources". I believe what the guide means >>> under "new source files" is e.g. when upstream does not provide an icon or >>> a .desktop or an .appdata.xml file (or a systemd .service or whatever) and >>> you add your own. This does not include "new upstream release tarball". >>> >>> I'll try to think of some way to make that more clear and submit a >>> suggestion to change the guide text. >> >> Somewhat tangentially, it may be worth recommending that the >> .gitignore be edited suitably for the project as one of the >> first steps in maintainence. >> >> By default 'fedpkg sources' will add the files being added >> to the lookaside cache to the .gitignore, but it will never >> remove older files, leading to an unnecessarily large >> .gitignore file. > > It probably isn't unreasonable to file an RFE against fedpkg to request > more intelligent behaviour. eg given a tarball filename in majority of > cases it is likely quite straightforward to identify the base name > eg match the filename against something like this > > (\w+)-(\d+(\.\d+)*).(zip|tar.\w+|tgz) > > And replace the 2nd part of the regex match with '*' to form the rule > to add to the .gitignore file.
Yeah, perhaps someone will get bored and do that. Years
ago, I submitted a patch to fedpkg/rpkg to have it resepct
the existing .gitignore, such that if you have a pattern
which matches the source being added, fedpkg won't add
another entry.
Another option would be to have fedpkg use the package N-V-R
to construct a gitignore entry and use that instead of the
filename if the filename matches the pattern. I don't think
it would be too hard to generate a pattern using a regex
either, I just haven't been bothered enough to work on a
patch.
--
Todd
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
I personally think we developed language because of our deep need to
complain.
-- Lily Tomlin
signature.asc
Description: PGP signature
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/ZRQU3C363UZ7UA6MNDRTLMUU5XEG5WG5/
