On Mon, 2018-07-09 at 02:27 +0200, Kevin Kofler wrote: > Jonathan Dieter wrote: > > And, since the patches to librepo all work and are in the review state > > right now, I expect that there will be few, if any, further changes to > > zchunk's API. > > I think these: > https://github.com/zchunk/zchunk/blob/8818802cbccde20f911ae527d40037e8fbea36bf/src/zck.c#L209 > https://github.com/zchunk/zchunk/blob/8818802cbccde20f911ae527d40037e8fbea36bf/src/zck.c#L215 > really need to change if you want zchunk to be usable for any other > application. The signature that marks the beginning of a chunk ought to be > passed through the API rather than hardcoded.
You are absolutely right, and this code will be removed shortly. Librepo doesn't actually use this code; it was there so I could manually compress repodata files for testing purposes before the librepo code was even written. Jonathan _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/CIRDDFAPQF76STSBQM5W5P7MBNFS3UCO/
