On Fri, Jul 06, 2018 at 08:15:04AM +0000, Petr Pisar wrote: > On 2018-07-05, Zbigniew Jędrzejewski-Szmek <zbys...@in.waw.pl> wrote: > > On Thu, Jul 05, 2018 at 01:19:38PM +0000, Zbigniew Jędrzejewski-Szmek wrote: > >> On Thu, Jul 05, 2018 at 02:41:01PM +0200, Florian Weimer wrote: > >> > On 07/05/2018 02:28 PM, Stephen Gallagher wrote: > >> > >So if we made this change, it should > >> > >probably go through the System-Wide Change process, the same as > >> > >any other item we remove from the default buildroot. > >> > > >> > I agree that it is a useful change, but also that it should go > >> > through the Change process. > >> OK. > >> > >> > On 07/05/2018 02:28 PM, Stephen Gallagher wrote: > >> > >My concern there would be that any package that needs langpacks > >> > >available in its build-system will now need to request them > >> > >specifically (for example, if the package does tests of > >> > >localization in %check). > >> I wonder how many such packages there are. I have seen many packages > >> which fail in an non-unicode locale, especially in tests. > >> glibc-minimal-langpack > >> contains C.UTF-8 so that is should not be an issue. So far I haven't > >> seen packages that would depend on the presence of some specific > >> locales, except that many packages need *some* utf-8 locale so they > >> set some specific one, usually en_US.utf8. A quick grep shows that > >> there's maybe a 50 such packages that would need to be adjusted. > > > > https://fedoraproject.org/wiki/Changes/Remove_glibc-langpacks-all_from_buildroot > > > mock sets locale to en_US.UTF-8 on every build in Koji. Look at any > build.log. Example: > > Mock Version: 1.3.4 > ENTER ['do'](['bash', '--login', '-c', '/usr/bin/rpmbuild -bs --target x86_64 > --nodeps /builddir/build/SPECS/libspf2.spec'], > chrootPath='/var/lib/mock/f29-build-12927811-944129/root'env={'TERM': > 'vt100', 'SHELL': '/bin/bash', 'HOME': '/builddir', 'HOSTNAME': 'mock', > 'PATH': '/usr/bin:/bin:/usr/sbin:/sbin', 'PROMPT_COMMAND': 'printf > "\\033]0;<mock-chroot>\\007"', 'PS1': '<mock-chroot> \\s-\\v\\$ ', 'LANG': > 'en_US.UTF-8'}shell=Falselogger=<mockbuild.trace_decorator.getLog object at > 0x7f6cc8fb3fd0>timeout=172800uid=1000gid=425user='mockbuild'nspawn_args=[]printOutput=False) > > Either you need to change mock to set C.UTF-8, or change your proposal to > install glibc-langpack-en instead of glibc-minimal-langpack. Otherwise various > programs will fail to set the locale at build time. E.g. perl is quite > noisy about that.
Thanks, that's a good point. Do you know where this is configured? When I run mock locally, it just passes the LC_*/LANG variables from the outside environment. I wonder if in koji this locale information is inherited from the default system settings, or if koji sets is specifically. Zbyszek _______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org Fedora Code of Conduct: https://getfedora.org/code-of-conduct.html List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/message/KONJ3NEVAYVXUBORVJRQFT4WPVEMQM44/
