On Sat, Mar 17, 2018 at 4:15 PM, Patrick マルタインアンドレアス Uiterwijk < puiterw...@redhat.com> wrote:
> > Don't be afraid of koji. :) > > I couldn't agree more, Koji's a pretty nice project to work on. > It might seems scary for newcomers because of all the ingrained knowledge > and assumptions, but once you get close the community is nice and friendly > :). > > > > > It is under active development. Of course, resources are limited and not > > everything can be taken on, but it's worth having the discussion. I have > > filed https://pagure.io/koji/issue/851 as a strawman and will try to > > solicit feedback on the idea. > > > > Thanks for doing that, though I don't know that it would resolve my > challenges. > First, I'd like to point out that by now I've basically solved the > problems for Bodhi and know how to deal with this change. > The main reason I wanted to send this email is because in things like > fedmsg's and other things, the NVRs as imported by Koji still leak out. > Even if the identifiers are colon-separated in all places and the N-S-V > encoded version is never exported out of koji, people will still need to > update scripts and tooling, and bringing that to people's attention was my > main reason for sending the email. > > I absolutely did not mean for my email to be judgemental, as I've not been > privy to the decision to allow dashes in multiple fields or the rest, so I > can't really judge the reasoning or the conclusion. > If it came over as judging, I'm sorry, I really just wanted to give people > a headsup so that they have some upfront time to update scripts before > seeing eithe module identifiers in fedmsg's or any other place. > > > Patrick, if https://pagure.io/koji/issue/851 was implemented would that > > resolve the challenge you were facing? If not, it might be worth > reaching > > out to koji-devel(a)lists.fedorahosted.org and discussing it further > there. > > It would not, but that's okay. > It would still mean that Module identifiers, whether you notice them as > N-S-V.C or N:S:V:C, are new, and all tooling and scripts will need to be > updated to handle those new identifiers. > I've read some parts of this thread and I see people are kind of saying "we have to update all the tooling". I really don't think there is tooling which needs to be updated *just* because of the delimiter. If something does not support modules and it should support modules and *needs* to work with Koji content-generator imported builds for some reason, it needs to updated to support modules and as part of this update, it can be told to use ':' as its output. If something does support modules already, it needs to be updated to support "context" field anyway and as part of this update ... ^ Note that this is just about the "module" type koji builds imported to Koji by MBS once the module is built. I think that t if you have no idea that those builds exist, you have nothing to update in your tool. What is impacted by this is: - Bodhi - which is easy to update and I've sent a PR which has been continued on by Patrick and is merged now. - Pungi - this supports ":" already. - MBS, pdc-updater - supports ":" already. Is there actually anything else? Regards, Jan Kaluza > > > > Cheers > > -- Dennis > > Patrick > _______________________________________________ > devel mailing list -- devel@lists.fedoraproject.org > To unsubscribe send an email to devel-le...@lists.fedoraproject.org >
_______________________________________________ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org
